Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 2371933003: Fix paint invalidation for composited vertical-rl having overflow (Closed)
Patch Set: - Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) 287 if (RuntimeEnabledFeatures::rootLayerScrollingEnabled())
288 return LayoutBlockFlow::visualOverflowRect(); 288 return LayoutBlockFlow::visualOverflowRect();
289 289
290 // Ditto when not in compositing mode. 290 // Ditto when not in compositing mode.
291 if (!usesCompositing()) 291 if (!usesCompositing())
292 return LayoutBlockFlow::visualOverflowRect(); 292 return LayoutBlockFlow::visualOverflowRect();
293 293
294 // In normal compositing mode, LayoutView doesn't actually apply clipping 294 // In normal compositing mode, LayoutView doesn't actually apply clipping
295 // on its descendants. Instead their visual overflow is propagated to 295 // on its descendants. Instead their visual overflow is propagated to
296 // compositor()->m_rootContentLayer for accelerated scrolling. 296 // compositor()->m_rootContentLayer for accelerated scrolling.
297 return LayoutRect(documentRect()); 297 return layoutOverflowRect();
chrishtr 2016/09/27 18:24:34 Not your fault, but could you add a TODO to resolv
Xianzhu 2016/09/27 18:36:23 Done.
298 } 298 }
299 299
300 LayoutRect LayoutView::localOverflowRectForPaintInvalidation() const 300 LayoutRect LayoutView::localOverflowRectForPaintInvalidation() const
301 { 301 {
302 // TODO(wangxianzhu): This is only required without rootLayerScrolls (though it is also correct 302 // TODO(wangxianzhu): This is only required without rootLayerScrolls (though it is also correct
303 // but unnecessary with rootLayerScrolls) because of the special LayoutView overflow model. 303 // but unnecessary with rootLayerScrolls) because of the special LayoutView overflow model.
304 return visualOverflowRect(); 304 return visualOverflowRect();
305 } 305 }
306 306
307 void LayoutView::mapLocalToAncestor(const LayoutBoxModelObject* ancestor, Transf ormState& transformState, MapCoordinatesFlags mode) const 307 void LayoutView::mapLocalToAncestor(const LayoutBoxModelObject* ancestor, Transf ormState& transformState, MapCoordinatesFlags mode) const
(...skipping 697 matching lines...) Expand 10 before | Expand all | Expand 10 after
1005 if (block) 1005 if (block)
1006 block->adjustChildDebugRect(rect); 1006 block->adjustChildDebugRect(rect);
1007 1007
1008 rect.setWidth(LayoutUnit(viewWidth(IncludeScrollbars))); 1008 rect.setWidth(LayoutUnit(viewWidth(IncludeScrollbars)));
1009 rect.setHeight(LayoutUnit(viewHeight(IncludeScrollbars))); 1009 rect.setHeight(LayoutUnit(viewHeight(IncludeScrollbars)));
1010 1010
1011 return rect; 1011 return rect;
1012 } 1012 }
1013 1013
1014 } // namespace blink 1014 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698