Issue 2371923002: Clamp Vulkan caps to INT_MAX

Issue 2371923002: Clamp Vulkan caps to INT_MAX (Closed)

Created:
4 years, 2 months ago by jvanverth1

Modified:
4 years, 2 months ago

Reviewers:
egdaniel, bsalomon

CC:
reviews_skia.org

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Clamp Vulkan caps to INT_MAX AMD sets some Vulkan caps values to 0xffffffff as a uint32_t, which overflows our int values and causes merry havok. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2371923002 Committed: https://skia.googlesource.com/skia/+/e78d4872cf2a0914752cdc99c4ec4a499cfd4e2c

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -11 lines)			Patch
	M	src/gpu/glsl/GrGLSLCaps.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
	M	src/gpu/vk/GrVkCaps.cpp	View		2 chunks	+9 lines, -7 lines	0 comments	Download

Total messages: 9 (4 generated)

jvanverth1

We're treating the sample counts as if they were ints everywhere we use them, so ...

4 years, 2 months ago (2016-09-26 20:34:27 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371923002/1

4 years, 2 months ago (2016-09-26 20:45:08 UTC) #7

commit-bot: I haz the power

4 years, 2 months ago (2016-09-27 10:33:11 UTC) #9

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e78d4872cf2a0914752cdc99c4ec4a499cfd4e2c