Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4908)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2371883002: Add PLMObserver::FlushMetricsOnAppEnterBackground. (Closed)
Patch Set: fix comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
index 7b8f7b8f772cd59318134ae87e51277d26a645c6..0a1bf48d2475c23ef94aaf2c9fa5c120d7301306 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
@@ -473,6 +473,16 @@ void PageLoadTracker::FlushMetricsOnAppEnterBackground() {
RecordAppBackgroundPageLoadCompleted(false);
app_entered_background_ = true;
}
+
+ const PageLoadExtraInfo info = ComputePageLoadExtraInfo();
+ for (auto it = observers_.begin(); it != observers_.end();) {
+ if ((*it)->FlushMetricsOnAppEnterBackground(timing_, info) ==
+ PageLoadMetricsObserver::STOP_OBSERVING) {
+ it = observers_.erase(it);
+ } else {
+ ++it;
+ }
+ }
}
void PageLoadTracker::NotifyClientRedirectTo(
@@ -915,6 +925,11 @@ void MetricsWebContentsObserver::OnInputEvent(
}
void MetricsWebContentsObserver::FlushMetricsOnAppEnterBackground() {
+ // Signal to observers that we've been backgrounded, in cases where the
+ // FlushMetricsOnAppEnterBackground callback gets invoked before the
+ // associated WasHidden callback.
+ WasHidden();
+
if (committed_load_)
committed_load_->FlushMetricsOnAppEnterBackground();
for (const auto& kv : provisional_loads_) {
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698