Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 2371873004: Change cursor to text selection (aka. I-beam) on the search box. (Closed)

Created:
4 years, 2 months ago by yamaguchi
Modified:
4 years, 2 months ago
Reviewers:
fukino
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org, hirono
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change cursor to text selection (aka. I-beam) on the search box. After this change, cursor:auto will be applied by the default of <input> elements. BUG=650586 TEST=manual test. Open files app and click the search button, then hover on the input. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/235b682f5601222ea3c4d5ce7d91730240d94129 Cr-Commit-Position: refs/heads/master@{#421448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
yamaguchi
The line was originally inserted by this change: https://codereview.chromium.org/26486006/diff2/1:3001/chrome/browser/resources/file_manager/css/file_manager.css +hirono to CC just in case ...
4 years, 2 months ago (2016-09-27 12:27:55 UTC) #10
fukino
lgtm
4 years, 2 months ago (2016-09-28 04:20:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371873004/1
4 years, 2 months ago (2016-09-28 04:40:41 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 04:45:34 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 04:47:44 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/235b682f5601222ea3c4d5ce7d91730240d94129
Cr-Commit-Position: refs/heads/master@{#421448}

Powered by Google App Engine
This is Rietveld 408576698