|
|
Chromium Code Reviews|
Created:
4 years, 2 months ago by yamaguchi Modified:
4 years, 2 months ago Reviewers:
fukino CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org, hirono Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionChange cursor to text selection (aka. I-beam) on the search box.
After this change, cursor:auto will be applied by the default of <input> elements.
BUG=650586
TEST=manual test. Open files app and click the search button, then hover on the input.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/235b682f5601222ea3c4d5ce7d91730240d94129
Cr-Commit-Position: refs/heads/master@{#421448}
Patch Set 1 #
Messages
Total messages: 19 (14 generated)
Description was changed from ========== Change cursor to text selection (aka. I-beam) on the search box. This change will remove extranous style so that the cursor:auto will be applied by the default for input element with text type. BUG=650586 TEST=manual test. open files app and click the search button, then hover on the input. ========== to ========== Change cursor to text selection (aka. I-beam) on the search box. This change will remove extranous style so that the cursor:auto will be applied by the default for input element with text type. BUG=650586 TEST=manual test. open files app and click the search button, then hover on the input. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Change cursor to text selection (aka. I-beam) on the search box. This change will remove extranous style so that the cursor:auto will be applied by the default for input element with text type. BUG=650586 TEST=manual test. open files app and click the search button, then hover on the input. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Change cursor to text selection (aka. I-beam) on the search box. After this change, cursor:auto will be applied by the default of <input> elements. BUG=650586 TEST=manual test. Open files app and click the search button, then hover on the input. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by yamaguchi@chromium.org
The CQ bit was unchecked by yamaguchi@chromium.org
The CQ bit was checked by yamaguchi@chromium.org
The CQ bit was unchecked by yamaguchi@chromium.org
The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yamaguchi@chromium.org changed reviewers: + fukino@chromium.org
The line was originally inserted by this change: https://codereview.chromium.org/26486006/diff2/1:3001/chrome/browser/resource... +hirono to CC just in case there were some specific reason we needed the line.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by yamaguchi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Change cursor to text selection (aka. I-beam) on the search box. After this change, cursor:auto will be applied by the default of <input> elements. BUG=650586 TEST=manual test. Open files app and click the search button, then hover on the input. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Change cursor to text selection (aka. I-beam) on the search box. After this change, cursor:auto will be applied by the default of <input> elements. BUG=650586 TEST=manual test. Open files app and click the search button, then hover on the input. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Change cursor to text selection (aka. I-beam) on the search box. After this change, cursor:auto will be applied by the default of <input> elements. BUG=650586 TEST=manual test. Open files app and click the search button, then hover on the input. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Change cursor to text selection (aka. I-beam) on the search box. After this change, cursor:auto will be applied by the default of <input> elements. BUG=650586 TEST=manual test. Open files app and click the search button, then hover on the input. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/235b682f5601222ea3c4d5ce7d91730240d94129 Cr-Commit-Position: refs/heads/master@{#421448} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/235b682f5601222ea3c4d5ce7d91730240d94129 Cr-Commit-Position: refs/heads/master@{#421448} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
