|
|
Chromium Code Reviews
DescriptionDisable dromaeo.jslibattrprototype on platforms.
BUG=650317
TBR=nednguyen,yukishiino
Committed: https://crrev.com/49f0731636ffc0b6a59e63e923dd74648ff23608
Cr-Commit-Position: refs/heads/master@{#421038}
Patch Set 1 #
Messages
Total messages: 27 (16 generated)
Description was changed from ========== Disable dromaeo.jslibattrprototype on platforms. BUG=650317 ========== to ========== Disable dromaeo.jslibattrprototype on platforms. BUG=650317 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Description was changed from ========== Disable dromaeo.jslibattrprototype on platforms. BUG=650317 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Disable dromaeo.jslibattrprototype on platforms. BUG=650317 TBR=nednguyen,yukishiino ==========
The CQ bit was checked by prasadv@chromium.org
The CQ bit was unchecked by prasadv@chromium.org
Description was changed from ========== Disable dromaeo.jslibattrprototype on platforms. BUG=650317 TBR=nednguyen,yukishiino ========== to ========== Disable dromaeo.jslibattrprototype on platforms. BUG=650317 TBR=nednguyen,yukishiino CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by prasadv@chromium.org
prasadv@chromium.org changed reviewers: + nednguyen@google.com, yukishiino@chromium.or
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by nednguyen@google.com
On 2016/09/26 20:17:10, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... In the bug, you mentioned webview, android & windows. Can you just disable this benchmark on those platforms?
On 2016/09/26 20:20:56, nednguyen wrote: > On 2016/09/26 20:17:10, commit-bot: I haz the power wrote: > > CQ is trying da patch. Follow status at > > > > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... > > In the bug, you mentioned webview, android & windows. Can you just disable this > benchmark on those platforms? This is also failing on: Android Galaxy S5 Perf (1) Android Nexus9 Perf (1) Android One Perf (1) Android Nexus6 WebView Perf (2) Win 10 Perf (4) Win 8 Perf (4) Win 7 x64 Perf (4) Win 7 Perf (4) Win 7 ATI GPU Perf (4) Mac 10.11 Perf (4) Mac 10.10 Perf (4) Mac HDD Perf (4) Linux Perf (4) That is the reason I disabled on all the platforms, I updated the bug accordingly.
lgtm
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_retina_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_...)
On 2016/09/26 23:17:53, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > mac_retina_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_...) I would remove CQ_INCLUDE_TRYBOTS
Description was changed from ========== Disable dromaeo.jslibattrprototype on platforms. BUG=650317 TBR=nednguyen,yukishiino CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Disable dromaeo.jslibattrprototype on platforms. BUG=650317 TBR=nednguyen,yukishiino ==========
The CQ bit was checked by prasadv@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Disable dromaeo.jslibattrprototype on platforms. BUG=650317 TBR=nednguyen,yukishiino ========== to ========== Disable dromaeo.jslibattrprototype on platforms. BUG=650317 TBR=nednguyen,yukishiino ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Disable dromaeo.jslibattrprototype on platforms. BUG=650317 TBR=nednguyen,yukishiino ========== to ========== Disable dromaeo.jslibattrprototype on platforms. BUG=650317 TBR=nednguyen,yukishiino Committed: https://crrev.com/49f0731636ffc0b6a59e63e923dd74648ff23608 Cr-Commit-Position: refs/heads/master@{#421038} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/49f0731636ffc0b6a59e63e923dd74648ff23608 Cr-Commit-Position: refs/heads/master@{#421038}
Message was sent while issue was closed.
Description was changed from ========== Disable dromaeo.jslibattrprototype on platforms. BUG=650317 TBR=nednguyen,yukishiino Committed: https://crrev.com/49f0731636ffc0b6a59e63e923dd74648ff23608 Cr-Commit-Position: refs/heads/master@{#421038} ========== to ========== Disable dromaeo.jslibattrprototype on platforms. BUG=650317 TBR=nednguyen,yukishiino Committed: https://crrev.com/49f0731636ffc0b6a59e63e923dd74648ff23608 Cr-Commit-Position: refs/heads/master@{#421038} ==========
Message was sent while issue was closed.
yukishiino@chromium.org changed reviewers: + yukishiino@chromium.org - yukishiino@chromium.or |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
