Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: test/cctest/wasm/test-run-wasm-64.cc

Issue 2371833007: [wasm] Initial signal handler (Closed)
Patch Set: Addressing some of Jochen's feedback Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/wasm/test-run-wasm-64.cc
diff --git a/test/cctest/wasm/test-run-wasm-64.cc b/test/cctest/wasm/test-run-wasm-64.cc
index 72cd31ce80fc3939ead94221ade1b473b7446402..60c26422c7d545d14fe40f2c3319653e2fb992e5 100644
--- a/test/cctest/wasm/test-run-wasm-64.cc
+++ b/test/cctest/wasm/test-run-wasm-64.cc
@@ -7,6 +7,7 @@
#include <string.h>
#include "src/base/bits.h"
+#include "src/trap-handler/trap-handler.h"
#include "src/wasm/wasm-macro-gen.h"
#include "test/cctest/cctest.h"
@@ -1460,6 +1461,13 @@ WASM_EXEC_TEST(I64Rol) {
}
WASM_EXEC_TEST_WITH_TRAP(StoreMem_offset_oob_i64) {
+ if (trap_handler::EnableTrapHandler()) {
+ // With trap handlers enabled, we need additional guard pages and such set
+ // up. This path does not enable these, so we skip this test. The behavior
+ // covered by this tests is also covered by mjsunit tests, such as
+ // test/mjsunit/wasm/import-memory.js
+ return;
+ }
static const MachineType machineTypes[] = {
MachineType::Int8(), MachineType::Uint8(), MachineType::Int16(),
MachineType::Uint16(), MachineType::Int32(), MachineType::Uint32(),

Powered by Google App Engine
This is Rietveld 408576698