Index: test/cctest/wasm/test-wasm-trap-position.cc |
diff --git a/test/cctest/wasm/test-wasm-trap-position.cc b/test/cctest/wasm/test-wasm-trap-position.cc |
index 91159f21548211af02f19ee4c7efd839e5b92b3b..7b953834b8ae1a622648dcea4d9eed47c7765910 100644 |
--- a/test/cctest/wasm/test-wasm-trap-position.cc |
+++ b/test/cctest/wasm/test-wasm-trap-position.cc |
@@ -3,6 +3,7 @@ |
// found in the LICENSE file. |
#include "src/assembler-inl.h" |
+#include "src/trap-handler/trap-handler.h" |
#include "src/wasm/wasm-macro-gen.h" |
#include "test/cctest/cctest.h" |
#include "test/cctest/compiler/value-helper.h" |
@@ -98,6 +99,14 @@ TEST(Unreachable) { |
// Trigger a trap for loading from out-of-bounds. |
TEST(IllegalLoad) { |
+ if (trap_handler::UseTrapHandler()) { |
+ // r.module().AddMemory() does not allocate guard pages, so we skip this |
+ // test for now when using trap handlers. The simple out of bounds access |
+ // case is covered by mjsunit tests, so we are still getting test coverage. |
+ // |
+ // TODO(eholk): make this test work with trap handlers. |
+ return; |
+ } |
WasmRunner<void> r(kExecuteCompiled); |
TestSignatures sigs; |
// Set the execution context, such that a runtime error can be thrown. |