src/trap-handler/OWNERS - Issue 2371833007: [wasm] Initial signal handler

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trap-handler/OWNERS

Issue 2371833007: [wasm] Initial signal handler (Closed)

Patch Set: Addressing some of Jochen's feedback Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 set noparent

	2

	3 eholk@chromium.org

	4 mseaborn@chromium.org

	5 mark@chromium.org
	titzer 2017/01/09 09:26:56 Does it make sense to have a MUC owner for this as Does it make sense to have a MUC owner for this as well? Eric Holk 2017/01/10 23:10:48 The OWNERS file is turning out to be a little tric Show quoted text On 2017/01/09 09:26:56, titzer wrote: > Does it make sense to have a MUC owner for this as well? The OWNERS file is turning out to be a little tricky, since Jochen said we can only have V8 committers here. The goal was to enforce that any changes to this directory are also reviewed by someone focused on security and crash handling. It seems like OWNERS isn't actually the best way to do this. Mark Mentovai 2017/01/10 23:11:52 Eric Holk wrote: Eric Holk wrote: Show quoted text > On 2017/01/09 09:26:56, titzer wrote: > > Does it make sense to have a MUC owner for this as well? > > The OWNERS file is turning out to be a little tricky, since Jochen said we can > only have V8 committers here. The goal was to enforce that any changes to this > directory are also reviewed by someone focused on security and crash handling. > It seems like OWNERS isn't actually the best way to do this. I believe I’m a v8 committer if that helps. Or at least I was once upon a time.
OLD	NEW