Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1763)

Issue 2371833005: Merge M54: "Transition to have nothing if background rendering evicts all frames." (Closed)

Created:
4 years, 2 months ago by DaleCurtis
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Merge M54: "Transition to have nothing if background rendering evicts all frames." If we're background rendering it's possible for us to expire all frames if the audio renderer advances too far ahead. In this case we need to transition into the HAVE_NOTHING state so the Renderer is aware we don't have frames. It seems possible for this bug to permanently hang video playback in release builds since the renderer has no idea what state we're in and the video renderer will never transition to have enough. BUG=630860 TEST=new unittest. Review-Url: https://codereview.chromium.org/2363983003 Cr-Commit-Position: refs/heads/master@{#420808} (cherry picked from commit fdde31284d8d1fb76451c55e6a579b34f5aa35f1) Committed: https://chromium.googlesource.com/chromium/src/+/1271a3e84bbf2d53341ba16c9a5ec501ca1d0698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -1 line) Patch
M media/renderers/video_renderer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/renderers/video_renderer_impl.cc View 3 chunks +17 lines, -1 line 0 comments Download
M media/renderers/video_renderer_impl_unittest.cc View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
4 years, 2 months ago (2016-09-27 20:06:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1271a3e84bbf2d53341ba16c9a5ec501ca1d0698.

Powered by Google App Engine
This is Rietveld 408576698