Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2371833002: Fix GCC uninitialized error (Closed)

Created:
4 years, 2 months ago by john.yan
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix GCC uninitialized error Fix "error: ‘maximum’ may be used uninitialized in this function" R=ahaas@chromium.org, titzer@chromium.org, rossberg@chromium.org BUG= Committed: https://crrev.com/09d645de97ddb2f4597a05fe0c9da2379900a33d Cr-Commit-Position: refs/heads/master@{#39741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/wasm/wasm-js.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
john.yan
PTAL
4 years, 2 months ago (2016-09-26 17:27:03 UTC) #3
titzer
On 2016/09/26 17:27:03, john.yan wrote: > PTAL lgtm
4 years, 2 months ago (2016-09-26 18:59:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371833002/1
4 years, 2 months ago (2016-09-26 19:18:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 19:50:19 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/09d645de97ddb2f4597a05fe0c9da2379900a33d Cr-Commit-Position: refs/heads/master@{#39741}
4 years, 2 months ago (2016-09-26 19:50:47 UTC) #10
ahaas
4 years, 2 months ago (2016-09-27 07:17:48 UTC) #11
Message was sent while issue was closed.
On 2016/09/26 at 19:50:47, commit-bot wrote:
> Patchset 1 (id:??) landed as
https://crrev.com/09d645de97ddb2f4597a05fe0c9da2379900a33d
> Cr-Commit-Position: refs/heads/master@{#39741}

Thanks for fixing this issue!

Powered by Google App Engine
This is Rietveld 408576698