In webkitpy-patch rebaseline-cl, don't try to rebaseline non-existent tests.

In webkitpy-patch rebaseline-cl, don't try to rebaseline non-existent tests.

BUG=649691
Committed: https://crrev.com/76d0c6c9d29209f0d205af6bf9ded17ee217fcc1
Cr-Commit-Position: refs/heads/master@{#421325}

[qyearsley, 2016-09-26 21:57:11]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org, jeffcarp@chromium.org

[qyearsley, 2016-09-26 21:57:12]

Note: Handling the case where for some reason we're trying to rebaseline tests
that don't exist is perhaps something that could be moved to the superclass
AbstractParallelRebaselineCommand, so that whenever
AbstractParallelRebaselineCommand._rebaseline is called it checks whether the
tests exist.

I think that this is something that could be refactored after making a "test
prefix list" class.

[qyearsley, 2016-09-27 18:22:08]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 18:22:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-09-27 18:28:54]

The code looks fine, but I'm uncertain about the motivation. How are we ending
up with requests to rebaseline tests that don't exist?

[qyearsley, 2016-09-27 18:36:08]

On 2016/09/27 at 18:28:54, dpranke wrote:
> The code looks fine, but I'm uncertain about the motivation. How are we ending
up with requests to rebaseline tests that don't exist?

I believe that there are two ways that that can happen right now (which should
both be fixed):

 1. update-w3c-test-expectations gets a list of modified files after import,
    including deleted files. Then it tries to rebaseline all those files,
    including deleted files.
 2. webkit-patch rebaseline-cl --only-changed-tests checks the list of changed
files in a CL
    from a request to Rietveld, which can also include deleted files.

So, I think that those cases should be fixed.

This CL would be a quick fix so that w3c-test-autoroller doesn't error out and
abort because of http://crbug.com/649691.

[Dirk Pranke, 2016-09-27 18:41:15]

okay, lgtm as a workaround. maybe add TODOs and link to bugs to get the other
things fixed, though? I don't like masking bugs indefinitely.

[qyearsley, 2016-09-27 18:54:45]

On 2016/09/27 at 18:41:15, dpranke wrote:
> okay, lgtm as a workaround. maybe add TODOs and link to bugs to get the other
things fixed, though? I don't like masking bugs indefinitely.

Sounds good, added TODO with bug link.

[qyearsley, 2016-09-27 18:54:50]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 18:55:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 20:27:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 20:27:52]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-09-27 20:42:59]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-09-27 20:42:59]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2371803003/#ps20001
(title: "Add TODO")

[commit-bot: I haz the power, 2016-09-27 20:43:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 20:48:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-27 20:50:50]

Description was changed from

==========
In webkitpy-patch rebaseline-cl, don't try to rebaseline non-existent tests.

BUG=649691
==========

to

==========
In webkitpy-patch rebaseline-cl, don't try to rebaseline non-existent tests.

BUG=649691

Committed: https://crrev.com/76d0c6c9d29209f0d205af6bf9ded17ee217fcc1
Cr-Commit-Position: refs/heads/master@{#421325}
==========

[commit-bot: I haz the power, 2016-09-27 20:50:52]

Patchset 2 (id:??) landed as
https://crrev.com/76d0c6c9d29209f0d205af6bf9ded17ee217fcc1
Cr-Commit-Position: refs/heads/master@{#421325}