Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 23718004: Fix definition of V8_LIBRT_NOT_AVAILABLE in v8.gyp since we test for it using #elif in time.cc. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer
Modified:
7 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix definition of V8_LIBRT_NOT_AVAILABLE in v8.gyp since we test for it using #elif in time.cc. TBR=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gyp/v8.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Benedikt Meurer
Committed patchset #1 manually as r16460 (presubmit successful).
7 years, 3 months ago (2013-09-01 15:03:43 UTC) #1
Jakob Kummerow
7 years, 3 months ago (2013-09-02 12:00:45 UTC) #2
Message was sent while issue was closed.
As discussed offline, this patch doesn't change anything, as defined values
default to 1 anyway. It doesn't hurt to keep it in for now, but the next cleanup
can take it out again.

Powered by Google App Engine
This is Rietveld 408576698