Remove stl_util's deletion functions from media/.

Remove stl_util's deletion functions from media/.

BUG=555865
Committed: https://crrev.com/386d72414e61c5e8155b66e2986fa0039f4b010a
Cr-Commit-Position: refs/heads/master@{#421679}

[Avi (use Gerrit), 2016-09-26 15:33:31]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 15:33:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 15:44:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 15:44:50]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Avi (use Gerrit), 2016-09-26 15:57:00]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 15:57:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 16:10:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 16:10:32]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Avi (use Gerrit), 2016-09-26 16:25:21]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 16:25:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 16:33:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 16:33:36]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Avi (use Gerrit), 2016-09-26 17:22:14]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 17:22:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 17:35:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 17:35:08]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Avi (use Gerrit), 2016-09-26 17:40:29]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 17:41:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 17:53:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 17:53:01]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Avi (use Gerrit), 2016-09-26 18:27:39]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 18:28:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 18:41:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 18:41:11]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Avi (use Gerrit), 2016-09-26 18:46:47]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 18:47:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 20:27:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 20:27:04]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Avi (use Gerrit), 2016-09-26 20:28:14]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 20:28:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-09-26 21:07:24]

avi@chromium.org changed reviewers:
+ servolk@chromium.org, wolenetz@chromium.org

[Avi (use Gerrit), 2016-09-26 21:07:26]

https://codereview.chromium.org/2371783002/diff/120001/media/filters/media_so...
File media/filters/media_source_state.h (right):

https://codereview.chromium.org/2371783002/diff/120001/media/filters/media_so...
media/filters/media_source_state.h:197: DemuxerStreamMap text_streams_;
The old ownership here, where the audio and video streams weren't owned but the
text streams were, was hard to reason about. What made it worse was that the
CreateDemuxerStreamCB sometimes returned owned objects and sometimes didn't.

So I made all streams the same.

When reviewing, please carefully review and verify the main ownership change
here, which is removing ownership of the text streams from the MediaSourceState
and having the ChunkDemuxer own them.

[commit-bot: I haz the power, 2016-09-26 21:45:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 21:45:21]

Dry run: This issue passed the CQ dry run.

[wolenetz, 2016-09-27 22:01:12]

OWNERS from gpu/ and cast/ are currently missing on this CL. I reviewed all for
this mostly mechanical change and:

LGTM % I'd prefer you also obtain LGT* from OWNER in cast/ and gpu/ before
landing.

https://codereview.chromium.org/2371783002/diff/120001/media/filters/chunk_de...
File media/filters/chunk_demuxer.cc (right):

https://codereview.chromium.org/2371783002/diff/120001/media/filters/chunk_de...
media/filters/chunk_demuxer.cc:1196: base::MakeUnique<ChunkDemuxerStream>(type,
splice_frames_enabled_,
:) good cleanup here, especially. Thank you.

https://codereview.chromium.org/2371783002/diff/120001/media/filters/frame_pr...
File media/filters/frame_processor.cc (right):

https://codereview.chromium.org/2371783002/diff/120001/media/filters/frame_pr...
media/filters/frame_processor.cc:296: // allow the stream to coalesce what might
otherwise be gaps in the buffered
:)

https://codereview.chromium.org/2371783002/diff/120001/media/filters/media_so...
File media/filters/media_source_state.h (right):

https://codereview.chromium.org/2371783002/diff/120001/media/filters/media_so...
media/filters/media_source_state.h:197: DemuxerStreamMap text_streams_;
On 2016/09/26 21:07:26, Avi wrote:
> The old ownership here, where the audio and video streams weren't owned but
the
> text streams were, was hard to reason about. What made it worse was that the
> CreateDemuxerStreamCB sometimes returned owned objects and sometimes didn't.
> 
> So I made all streams the same.
> 
> When reviewing, please carefully review and verify the main ownership change
> here, which is removing ownership of the text streams from the
MediaSourceState
> and having the ChunkDemuxer own them.

Acknowledged.

https://codereview.chromium.org/2371783002/diff/120001/media/gpu/ipc/service/...
File media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc (right):

https://codereview.chromium.org/2371783002/diff/120001/media/gpu/ipc/service/...
media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc:181: if (owner_)
nit: include a comment here like on l.273, too?

https://codereview.chromium.org/2371783002/diff/120001/media/gpu/ipc/service/...
media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc:352: // here instead of
making the code unnecessary complicated.
drive-by nit: s/unnecessary/unnecessarily/

[Avi (use Gerrit), 2016-09-28 15:39:49]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 15:40:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-09-28 15:41:45]

avi@chromium.org changed reviewers:
+ dalecurtis@chromium.org, miu@chromium.org

[Avi (use Gerrit), 2016-09-28 15:41:46]

miu: please review cast files
dalecurtis: please review gpu files

https://codereview.chromium.org/2371783002/diff/120001/media/filters/chunk_de...
File media/filters/chunk_demuxer.cc (right):

https://codereview.chromium.org/2371783002/diff/120001/media/filters/chunk_de...
media/filters/chunk_demuxer.cc:1196: base::MakeUnique<ChunkDemuxerStream>(type,
splice_frames_enabled_,
On 2016/09/27 22:01:11, wolenetz wrote:
> :) good cleanup here, especially. Thank you.

Acknowledged.

https://codereview.chromium.org/2371783002/diff/120001/media/filters/frame_pr...
File media/filters/frame_processor.cc (right):

https://codereview.chromium.org/2371783002/diff/120001/media/filters/frame_pr...
media/filters/frame_processor.cc:296: // allow the stream to coalesce what might
otherwise be gaps in the buffered
On 2016/09/27 22:01:11, wolenetz wrote:
> :)

I turned on spell-checking in my text editor, so now I fix typos everywhere I
go.

https://codereview.chromium.org/2371783002/diff/120001/media/gpu/ipc/service/...
File media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc (right):

https://codereview.chromium.org/2371783002/diff/120001/media/gpu/ipc/service/...
media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc:181: if (owner_)
On 2016/09/27 22:01:12, wolenetz wrote:
> nit: include a comment here like on l.273, too?

Done.

https://codereview.chromium.org/2371783002/diff/120001/media/gpu/ipc/service/...
media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc:352: // here instead of
making the code unnecessary complicated.
On 2016/09/27 22:01:12, wolenetz wrote:
> drive-by nit: s/unnecessary/unnecessarily/

I'll spell-check the whole file while I'm at it, then :)

[DaleCurtis, 2016-09-28 17:21:46]

lgtm

[commit-bot: I haz the power, 2016-09-28 17:48:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 17:48:18]

Dry run: This issue passed the CQ dry run.

[miu, 2016-09-28 23:16:08]

media/cast lgtm

[Avi (use Gerrit), 2016-09-28 23:20:19]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-09-28 23:20:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
wolenetz@chromium.org
Link to the patchset: https://codereview.chromium.org/2371783002/#ps140001
(title: "wolenetz")

[commit-bot: I haz the power, 2016-09-28 23:20:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 23:26:23]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-09-28 23:28:47]

Description was changed from

==========
Remove stl_util's deletion functions from media/.

BUG=555865
==========

to

==========
Remove stl_util's deletion functions from media/.

BUG=555865

Committed: https://crrev.com/386d72414e61c5e8155b66e2986fa0039f4b010a
Cr-Commit-Position: refs/heads/master@{#421679}
==========

[commit-bot: I haz the power, 2016-09-28 23:28:48]

Patchset 8 (id:??) landed as
https://crrev.com/386d72414e61c5e8155b66e2986fa0039f4b010a
Cr-Commit-Position: refs/heads/master@{#421679}