Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2371773004: [inspector] run microtasks after async Runtime.evaluate (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
Reviewers:
alph, dgozman
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] run microtasks after async Runtime.evaluate If promise was resolved before adding handler in Runtime.evaluate method then this callback won't be called. We need to run microtasks after adding handlers. R=dgozman@chromium.org,alph@chromium.org BUG=chromium:650890 Committed: https://crrev.com/ff135975b0078aac1cc64415033ec721401ad461 Cr-Commit-Position: refs/heads/master@{#39793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/inspector/v8-runtime-agent-impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
kozy
Dmitry, please take a look!
4 years, 2 months ago (2016-09-27 17:15:56 UTC) #1
dgozman
Let's have a test.
4 years, 2 months ago (2016-09-27 17:53:35 UTC) #4
dgozman
lgtm
4 years, 2 months ago (2016-09-27 18:00:24 UTC) #5
kozy
Alexei, please take a look!
4 years, 2 months ago (2016-09-27 18:43:11 UTC) #6
alph
lgtm
4 years, 2 months ago (2016-09-27 19:29:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371773004/1
4 years, 2 months ago (2016-09-27 19:32:20 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 19:42:22 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 19:42:42 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff135975b0078aac1cc64415033ec721401ad461
Cr-Commit-Position: refs/heads/master@{#39793}

Powered by Google App Engine
This is Rietveld 408576698