Clean up Android DownloadManager code as most download now go through Chrome Network stack

Clean up Android DownloadManager code as most download now go through Chrome Network stack

The only exception is OMA DRM download.
And it only applies to context menu download interception.
Clean up the remaining unused code now.

BUG=647755
Committed: https://crrev.com/5fc08cfb098acce49344d2e89cc27c915903f81c
Cr-Commit-Position: refs/heads/master@{#421332}

[qinmin, 2016-09-26 22:16:47]

qinmin@chromium.org changed reviewers:
+ tedchoc@chromium.org

[qinmin, 2016-09-26 22:16:47]

PTAL

[Ted C, 2016-09-27 17:45:23]

lgtm

https://codereview.chromium.org/2371773003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java
(left):

https://codereview.chromium.org/2371773003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java:560:
private static boolean isDangerousExtension(String ext) {
do we need to add this logic to native now?

[qinmin, 2016-09-27 19:26:50]

https://codereview.chromium.org/2371773003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java
(left):

https://codereview.chromium.org/2371773003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java:560:
private static boolean isDangerousExtension(String ext) {
On 2016/09/27 17:45:22, Ted C wrote:
> do we need to add this logic to native now?

There is a warning when openning an apk file on android, so .apk is not
considered dangerous at download time now

[qinmin, 2016-09-27 19:26:56]

The CQ bit was checked by qinmin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 19:27:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 20:01:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 20:01:11]

Dry run: This issue passed the CQ dry run.

[qinmin, 2016-09-27 20:53:33]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2016-09-27 20:53:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 21:00:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-27 21:03:35]

Description was changed from

==========
Clean up Android DownloadManager code as most download now go through Chrome
Network stack

The only exception is OMA DRM download.
And it only applies to context menu download interception.
Clean up the remaining unused code now.

BUG=647755
==========

to

==========
Clean up Android DownloadManager code as most download now go through Chrome
Network stack

The only exception is OMA DRM download.
And it only applies to context menu download interception.
Clean up the remaining unused code now.

BUG=647755

Committed: https://crrev.com/5fc08cfb098acce49344d2e89cc27c915903f81c
Cr-Commit-Position: refs/heads/master@{#421332}
==========

[commit-bot: I haz the power, 2016-09-27 21:03:36]

Patchset 1 (id:??) landed as
https://crrev.com/5fc08cfb098acce49344d2e89cc27c915903f81c
Cr-Commit-Position: refs/heads/master@{#421332}