Introduce EmbedderReachableReferenceReporter

Introduce EmbedderReachableReferenceReporter

This cl introduces reporter to the embedder heap tracer. Heap tracer uses
reporter to report reachable objects from embedder heap. This refactoring is a
step towards being able to take heap snapshots with wrapper tracing.

LOG=no
BUG=468240
Committed: https://crrev.com/0698f1066128804c6ef6e0b92d4530a96e116dd4
Cr-Commit-Position: refs/heads/master@{#39824}

[Marcel Hlopko, 2016-09-26 11:24:12]

hlopko@chromium.org changed reviewers:
+ hpayer@chromium.org, mlippautz@chromium.org

[Marcel Hlopko, 2016-09-26 11:24:18]

Ptal :)

[Marcel Hlopko, 2016-09-26 11:25:31]

The CQ bit was checked by hlopko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 11:25:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 11:32:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 11:32:07]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Marcel Hlopko, 2016-09-27 11:19:13]

The CQ bit was checked by hlopko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 11:19:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 11:47:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 11:47:16]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-09-27 13:25:33]

https://codereview.chromium.org/2371733002/diff/20001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2371733002/diff/20001/include/v8.h#newcode6101
include/v8.h:6101: class V8_EXPORT EmbedderHeapTracer {
How about making EmbedderReachableReferenceReporter a member (with getters and
setters) of EmbedderHeapTracer? This way we would not need to pass it in for
TracePrologue and we could keep the symmetry of TracePrologue TraceEpilogue.

wdyt?

https://codereview.chromium.org/2371733002/diff/20001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/2371733002/diff/20001/src/heap/heap.h#newcode526
src/heap/heap.h:526: class TracePossibleWrapperReporter;
Move to the other fwd decls that can be found at the top of the file.

https://codereview.chromium.org/2371733002/diff/20001/src/heap/heap.h#newcode...
src/heap/heap.h:1215: EmbedderReachableReferenceReporter*
GetEmbedderReachableReferenceReporter() {
Remove "Get". I'd actually prefer a lower case getter here because it just
returns the field.

[Michael Lippautz, 2016-09-27 13:41:51]

As discussed in chat, lets move them together, either in Heap, or in
MarkCompactCollector.

https://codereview.chromium.org/2371733002/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/2371733002/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:821: heap_->GetEmbedderReachableReferenceReporter());
You are in MC, no need to ref 'this' through heap_ :)

[Marcel Hlopko, 2016-09-28 07:58:50]

The CQ bit was checked by hlopko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 07:59:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marcel Hlopko, 2016-09-28 08:03:04]

All done, ptal :) I see the cl could be split in two, one with moving heap
tracer to heap, second with reporter. Let me know if it's too complex to review
now.

[Marcel Hlopko, 2016-09-28 08:03:57]

The CQ bit was checked by hlopko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 08:04:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 08:33:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 08:33:08]

Dry run: This issue passed the CQ dry run.

[Marcel Hlopko, 2016-09-28 10:24:43]

The CQ bit was checked by hlopko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 10:24:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 10:27:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 10:27:18]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-09-28 12:13:13]

LGTM 

Please also wait for Hannes on this one.

https://codereview.chromium.org/2371733002/diff/60001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/2371733002/diff/60001/src/heap/heap.h#newcode...
src/heap/heap.h:1208: bool UsingEmbedderHeapTracer() { return
embedder_heap_tracer(); }
return embedder_heap_tracer() != nullptr;

[Hannes Payer (out of office), 2016-09-28 12:50:06]

lgtm

[Marcel Hlopko, 2016-09-28 12:53:07]

The CQ bit was checked by hlopko@chromium.org

[commit-bot: I haz the power, 2016-09-28 12:53:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 12:54:59]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-28 12:55:23]

Description was changed from

==========
Introduce EmbedderReachableReferenceReporter

This cl introduces reporter to the embedder heap tracer. Heap tracer uses
reporter to report reachable objects from embedder heap. This refactoring is a
step towards being able to take heap snapshots with wrapper tracing.

LOG=no
BUG=468240
==========

to

==========
Introduce EmbedderReachableReferenceReporter

This cl introduces reporter to the embedder heap tracer. Heap tracer uses
reporter to report reachable objects from embedder heap. This refactoring is a
step towards being able to take heap snapshots with wrapper tracing.

LOG=no
BUG=468240

Committed: https://crrev.com/0698f1066128804c6ef6e0b92d4530a96e116dd4
Cr-Commit-Position: refs/heads/master@{#39824}
==========

[commit-bot: I haz the power, 2016-09-28 12:55:25]

Patchset 4 (id:??) landed as
https://crrev.com/0698f1066128804c6ef6e0b92d4530a96e116dd4
Cr-Commit-Position: refs/heads/master@{#39824}