Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 237173002: Roll ANGLE. (Closed)

Created:
6 years, 8 months ago by Geoff Lang
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com, Stephen White
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update test expectations #

Patch Set 3 : Try new DEPS location #

Patch Set 4 : #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -41 lines) Patch
M DEPS View 1 2 3 4 5 6 7 1 chunk +1 line, -2 lines 0 comments Download
M expectations/gm/ignored-tests.txt View 1 2 3 4 5 6 7 1 chunk +17 lines, -0 lines 0 comments Download
M gyp/angle.gyp View 1 2 2 chunks +6 lines, -39 lines 0 comments Download
M gyp/common_conditions.gypi View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
Geoff Lang
PTAL, should I try running this against any trybots?
6 years, 8 months ago (2014-04-14 15:43:47 UTC) #1
bsalomon
On 2014/04/14 15:43:47, Geoff Lang wrote: > PTAL, should I try running this against any ...
6 years, 8 months ago (2014-04-15 14:36:31 UTC) #2
Geoff Lang
On 2014/04/15 14:36:31, bsalomon wrote: > On 2014/04/14 15:43:47, Geoff Lang wrote: > > PTAL, ...
6 years, 8 months ago (2014-04-15 15:52:37 UTC) #3
bsalomon
On 2014/04/15 15:52:37, Geoff Lang wrote: > On 2014/04/15 14:36:31, bsalomon wrote: > > On ...
6 years, 8 months ago (2014-04-15 16:09:07 UTC) #4
Geoff Lang
On 2014/04/15 16:09:07, bsalomon wrote: > On 2014/04/15 15:52:37, Geoff Lang wrote: > > On ...
6 years, 8 months ago (2014-04-15 17:08:38 UTC) #5
bsalomon
Ravi, any idea what the problem might be?
6 years, 8 months ago (2014-04-15 17:41:58 UTC) #6
rmistry
On 2014/04/15 17:41:58, bsalomon wrote: > Ravi, any idea what the problem might be? Looks ...
6 years, 8 months ago (2014-04-15 17:48:30 UTC) #7
Geoff Lang
On 2014/04/15 17:48:30, rmistry wrote: > On 2014/04/15 17:41:58, bsalomon wrote: > > Ravi, any ...
6 years, 8 months ago (2014-04-15 18:00:33 UTC) #8
Geoff Lang
Looks like the tests are passing now, are we comfortable committing this?
6 years, 8 months ago (2014-04-17 15:36:03 UTC) #9
bsalomon
lgtm
6 years, 8 months ago (2014-04-17 17:23:44 UTC) #10
Geoff Lang
The CQ bit was checked by geofflang@chromium.org
6 years, 8 months ago (2014-04-17 17:24:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/geofflang@chromium.org/237173002/80001
6 years, 8 months ago (2014-04-17 17:24:21 UTC) #12
commit-bot: I haz the power
Change committed as 14243
6 years, 8 months ago (2014-04-17 18:29:19 UTC) #13
bsalomon
A revert of this CL has been created in https://codereview.chromium.org/238863006/ by bsalomon@google.com. The reason for ...
6 years, 8 months ago (2014-04-17 21:30:44 UTC) #14
Geoff Lang
The CQ bit was checked by geofflang@chromium.org
6 years, 7 months ago (2014-05-01 18:56:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/geofflang@chromium.org/237173002/130001
6 years, 7 months ago (2014-05-01 18:56:55 UTC) #16
commit-bot: I haz the power
Change committed as 14509
6 years, 7 months ago (2014-05-01 19:22:25 UTC) #17
djsollen
I'm going to revert this shortly unless a fix is proposed, but this is failing ...
6 years, 7 months ago (2014-05-01 20:06:47 UTC) #18
Geoff Lang
On 2014/05/01 20:06:47, djsollen wrote: > I'm going to revert this shortly unless a fix ...
6 years, 7 months ago (2014-05-01 20:10:24 UTC) #19
djsollen
6 years, 7 months ago (2014-05-01 20:12:34 UTC) #20
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/264733006/ by djsollen@google.com.

The reason for reverting is: breaking the buildbots (see
http://108.170.220.76:10117/builders/Build-Win7-VS2010-x86-Release-ANGLE/buil....

Powered by Google App Engine
This is Rietveld 408576698