Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: third_party/lcms2-2.6/0008-memory-leak-Type_MPEmatrix_Read.patch

Issue 2371723003: Fix memory leak in lcms, MPEmatrix_Read (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/lcms2-2.6/README.pdfium » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/lcms2-2.6/0008-memory-leak-Type_MPEmatrix_Read.patch
diff --git a/third_party/lcms2-2.6/0008-memory-leak-Type_MPEmatrix_Read.patch b/third_party/lcms2-2.6/0008-memory-leak-Type_MPEmatrix_Read.patch
new file mode 100644
index 0000000000000000000000000000000000000000..93ee3d3fde1cf547d130eaecceb949a52e3fd8b1
--- /dev/null
+++ b/third_party/lcms2-2.6/0008-memory-leak-Type_MPEmatrix_Read.patch
@@ -0,0 +1,30 @@
+diff --git a/third_party/lcms2-2.6/src/cmstypes.c b/third_party/lcms2-2.6/src/cmstypes.c
+index 441d6bb..15199c7 100644
+--- a/third_party/lcms2-2.6/src/cmstypes.c
++++ b/third_party/lcms2-2.6/src/cmstypes.c
+@@ -4203,7 +4203,11 @@ void *Type_MPEmatrix_Read(struct _cms_typehandler_struct* self, cmsIOHANDLER* io
+
+ cmsFloat32Number v;
+
+- if (!_cmsReadFloat32Number(io, &v)) return NULL;
++ if (!_cmsReadFloat32Number(io, &v)) {
++ _cmsFree(self ->ContextID, Matrix);
++ _cmsFree(self ->ContextID, Offsets);
++ return NULL;
++ }
+ Matrix[i] = v;
+ }
+
+@@ -4212,7 +4216,11 @@ void *Type_MPEmatrix_Read(struct _cms_typehandler_struct* self, cmsIOHANDLER* io
+
+ cmsFloat32Number v;
+
+- if (!_cmsReadFloat32Number(io, &v)) return NULL;
++ if (!_cmsReadFloat32Number(io, &v)) {
++ _cmsFree(self ->ContextID, Matrix);
++ _cmsFree(self ->ContextID, Offsets);
++ return NULL;
++ }
+ Offsets[i] = v;
+ }
+
« no previous file with comments | « no previous file | third_party/lcms2-2.6/README.pdfium » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698