Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.cc

Issue 2371723002: Power Save Blocker: Eliminate passing ViewAndroid as WeakPtr (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/render_frame_devtools_agent_host.cc
diff --git a/content/browser/devtools/render_frame_devtools_agent_host.cc b/content/browser/devtools/render_frame_devtools_agent_host.cc
index e137b9e3e9c6232d3f31fde2598b876d4c8e3d3f..f83a1ff44287542dde4a887d13eb93c48e22251f 100644
--- a/content/browser/devtools/render_frame_devtools_agent_host.cc
+++ b/content/browser/devtools/render_frame_devtools_agent_host.cc
@@ -689,10 +689,8 @@ void RenderFrameDevToolsAgentHost::CreatePowerSaveBlocker() {
BrowserThread::GetTaskRunnerForThread(BrowserThread::UI),
BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE)));
if (web_contents()->GetNativeView()) {
- view_weak_factory_.reset(new base::WeakPtrFactory<ui::ViewAndroid>(
- web_contents()->GetNativeView()));
power_save_blocker_->InitDisplaySleepBlocker(
- view_weak_factory_->GetWeakPtr());
+ web_contents()->GetNativeView());
}
#endif
}
@@ -790,12 +788,6 @@ void RenderFrameDevToolsAgentHost::DidFailProvisionalLoad(
DiscardPending();
}
-void RenderFrameDevToolsAgentHost::WebContentsDestroyed() {
-#if defined(OS_ANDROID)
- view_weak_factory_.reset();
-#endif
-}
-
void RenderFrameDevToolsAgentHost::WasShown() {
CreatePowerSaveBlocker();
}
« no previous file with comments | « content/browser/devtools/render_frame_devtools_agent_host.h ('k') | content/browser/media/media_web_contents_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698