Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 2371723002: Power Save Blocker: Eliminate passing ViewAndroid as WeakPtr (Closed)

Created:
4 years, 2 months ago by blundell
Modified:
4 years, 2 months ago
Reviewers:
boliu
CC:
chromium-reviews, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Power Save Blocker: Eliminate passing ViewAndroid as WeakPtr As of https://codereview.chromium.org/2103243002/, PowerSaveBlockerAndroid accesses the ViewAndroid pointer it is passed only at a time when that ViewAndroid pointer is guaranteed to be valid. This CL moves PowerSaveBlockerAndroid away from consuming the ViewAndroid pointer as a WeakPtr. The concrete motivation is to eliminate WakeLockServiceContext needing to listen for WebContentsObserver::WebContentsDestroyed() as part of decoupling the wake lock service from //content. BUG=612346 Committed: https://crrev.com/87cd0848a0d1453e7553a72b0686d42fabf8ff3a Cr-Commit-Position: refs/heads/master@{#421169}

Patch Set 1 #

Patch Set 2 : Remove weak_ptr.h include #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -55 lines) Patch
M content/browser/devtools/render_frame_devtools_agent_host.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 2 chunks +1 line, -9 lines 0 comments Download
M content/browser/media/media_web_contents_observer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/media/media_web_contents_observer.cc View 2 chunks +1 line, -6 lines 0 comments Download
M content/browser/wake_lock/wake_lock_service_context.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/wake_lock/wake_lock_service_context.cc View 2 chunks +1 line, -9 lines 0 comments Download
M device/power_save_blocker/power_save_blocker.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M device/power_save_blocker/power_save_blocker_android.cc View 3 chunks +11 lines, -19 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
boliu
lgtm
4 years, 2 months ago (2016-09-26 17:46:00 UTC) #6
boliu
On 2016/09/26 17:46:00, boliu wrote: > lgtm oh, I didn't look closely, but probably could ...
4 years, 2 months ago (2016-09-26 17:51:18 UTC) #7
blundell
Thanks! Removed weak_ptr.h from power_save_blocker.h.
4 years, 2 months ago (2016-09-27 10:45:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371723002/40001
4 years, 2 months ago (2016-09-27 10:46:23 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-27 11:30:50 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 11:32:32 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/87cd0848a0d1453e7553a72b0686d42fabf8ff3a
Cr-Commit-Position: refs/heads/master@{#421169}

Powered by Google App Engine
This is Rietveld 408576698