sync/internal_api/syncapi_server_connection_manager.h - Issue 23717047: Retry: sync: Gracefully handle early shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/syncapi_server_connection_manager.h

Issue 23717047: Retry: sync: Gracefully handle early shutdown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move signals to SyncaBackendHost::Core Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/syncapi_server_connection_manager.h

diff --git a/sync/internal_api/syncapi_server_connection_manager.h b/sync/internal_api/syncapi_server_connection_manager.h

index 21ede838b4b4862e7142a89b4be5e33b62100c7c..480504508298adabaaf693d0fd912c117e76cc34 100644

--- a/sync/internal_api/syncapi_server_connection_manager.h

+++ b/sync/internal_api/syncapi_server_connection_manager.h

@@ -55,14 +55,16 @@ class SYNC_EXPORT_PRIVATE SyncAPIServerConnectionManager

int port,

bool use_ssl,

bool use_oauth2_token,

- HttpPostProviderFactory* factory);

+ HttpPostProviderFactory* factory,

+ CancelationSignal* cancelation_signal);

virtual ~SyncAPIServerConnectionManager();

// ServerConnectionManager overrides.

virtual Connection* MakeConnection() OVERRIDE;

- virtual void TerminateAllIO() OVERRIDE;

private:

+ FRIEND_TEST_ALL_PREFIXES(SyncAPIServerConnectionManagerTest,

+ VeryEarlyAbortPost);

FRIEND_TEST_ALL_PREFIXES(SyncAPIServerConnectionManagerTest, EarlyAbortPost);

FRIEND_TEST_ALL_PREFIXES(SyncAPIServerConnectionManagerTest, AbortPost);