Issue 23717034: webview: Fix the code to disallow external protocol handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23717034: webview: Fix the code to disallow external protocol handlers. (Closed)

Created:
7 years, 3 months ago by sadrul

Modified:
7 years, 3 months ago

Reviewers:
jam

CC:
chromium-reviews, Fady Samuel

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

webview: Fix the code to disallow external protocol handlers. RenderViewHost::FromID() should only be accessed in the UI thread. So use ExtensionRendererState::GetWebViewInfo() instead to determine if the render view is hosting a guest. BUG=230655 R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221724

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc	View		2 chunks	+6 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

sadrul

7 years, 3 months ago (2013-09-06 17:26:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r221724 (presubmit successful).