Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

Issue 23717029: Disable submit button briefly when launching rAc dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
index 096300f85eafe1bc326cb824f0a8cf0a1b11b5dd..d9adb1999c450eab2cc7c747ef55494a7cbb2f68 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
@@ -281,6 +281,14 @@ class TestAutofillDialogController
OnWalletSigninError();
}
+ void SimulateSubmitButtonDelayBegin() {
+ AutofillDialogControllerImpl::SubmitButtonDelayBegin();
+ }
+
+ void SimulateSubmitButtonDelayEnd() {
+ AutofillDialogControllerImpl::OnSubmitButtonDelayEnd();
+ }
+
MOCK_METHOD0(LoadRiskFingerprintData, void());
using AutofillDialogControllerImpl::OnDidLoadRiskFingerprintData;
using AutofillDialogControllerImpl::IsEditingExistingData;
@@ -311,6 +319,14 @@ class TestAutofillDialogController
billing_profile.Pass());
}
+ virtual void SubmitButtonDelayBegin() OVERRIDE {
+ // Ignore in testing.
+ }
+
+ virtual void OnSubmitButtonDelayEnd() OVERRIDE {
+ // Ignore in testing.
+ }
+
private:
// To specify our own metric logger.
virtual const AutofillMetrics& GetMetricLogger() const OVERRIDE {
@@ -2395,4 +2411,12 @@ TEST_F(AutofillDialogControllerTest,
EXPECT_FALSE(controller()->ShouldSaveInChrome());
}
+TEST_F(AutofillDialogControllerTest, SubmitButtonDelayedOnStart) {
+ controller()->SimulateSubmitButtonDelayBegin();
+ SwitchToAutofill();
+ EXPECT_FALSE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
+ controller()->SimulateSubmitButtonDelayEnd();
+ EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
+}
+
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698