Disable submit button briefly when launching rAc dialog

chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/guid.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 223 matching lines @@
                                 const std::string&)>& callback,
       MockNewCreditCardBubbleController* mock_new_card_bubble_controller)
       : AutofillDialogControllerImpl(contents,
                                      form_structure,
                                      source_url,
                                      callback),
         metric_logger_(metric_logger),
         mock_wallet_client_(
             Profile::FromBrowserContext(contents->GetBrowserContext())->
                 GetRequestContext(), this),
-        mock_new_card_bubble_controller_(mock_new_card_bubble_controller) {}
+        mock_new_card_bubble_controller_(mock_new_card_bubble_controller),
+        submit_button_delay_number_(0) {}
 
   virtual ~TestAutofillDialogController() {}
 
   virtual AutofillDialogView* CreateView() OVERRIDE {
     return new testing::NiceMock<TestAutofillDialogView>();
   }
 
   void Init(content::BrowserContext* browser_context) {
     test_manager_.Init(browser_context);
   }
@@ skipping 16 matching lines @@
     OnWalletSigninError();
   }
 
   // Skips past the 2 second wait between FinishSubmit and DoFinishSubmit.
   void ForceFinishSubmit() {
 #if defined(TOOLKIT_VIEWS)
     DoFinishSubmit();
 #endif
   }
 
+  void SimulateSubmitButtonDelayBegin() {
+    // 60 second delay to avoid test flakiness. The test would be flaky if this

[Evan Stade, 2013/09/05 16:29:44]

I don't think this is necessary. The test executes synchronously so any delay
(even 0ms) would be enough to ensure that the callback doesn't run till after
the test is done.

[please use gerrit instead, 2013/09/05 18:40:49]

Using the same delay in production and in testing.

+    // delay expired before the test finishes. This delay does not affect
+    // execution time of the test.
+    static const int kSimulatedSubmitButtonDelaySeconds = 60;
+    AutofillDialogControllerImpl::SubmitButtonDelayBegin(
+        base::TimeDelta::FromSeconds(kSimulatedSubmitButtonDelaySeconds));
+  }
+
+  void SimulateSubmitButtonDelayEnd() {
+    AutofillDialogControllerImpl::SubmitButtonDelayEndForTesting();
+  }
+
+  // Returns the number of times that the submit button was delayed.
+  int get_submit_button_delay_number() const {
+    return submit_button_delay_number_;
+  }
+
   MOCK_METHOD0(LoadRiskFingerprintData, void());
   using AutofillDialogControllerImpl::OnDidLoadRiskFingerprintData;
   using AutofillDialogControllerImpl::IsEditingExistingData;
 
  protected:
   virtual PersonalDataManager* GetManager() OVERRIDE {
     return &test_manager_;
   }
 
   virtual wallet::WalletClient* GetWalletClient() OVERRIDE {
@@ skipping 10 matching lines @@
     return true;
   }
 
   virtual void ShowNewCreditCardBubble(
       scoped_ptr<CreditCard> new_card,
       scoped_ptr<AutofillProfile> billing_profile) OVERRIDE {
     mock_new_card_bubble_controller_->Show(new_card.Pass(),
                                            billing_profile.Pass());
   }
 
+  // AutofillDialogControllerImpl calls this method before showing the dialog
+  // window.
+  virtual void SubmitButtonDelayBegin(base::TimeDelta delay) OVERRIDE {
+    // Do not delay enabling the submit button in testing.
+    submit_button_delay_number_++;
+  }
+
  private:
   // To specify our own metric logger.
   virtual const AutofillMetrics& GetMetricLogger() const OVERRIDE {
     return metric_logger_;
   }
 
   const AutofillMetrics& metric_logger_;
   TestPersonalDataManager test_manager_;
   testing::NiceMock<wallet::MockWalletClient> mock_wallet_client_;
   GURL open_tab_url_;
   MockNewCreditCardBubbleController* mock_new_card_bubble_controller_;
 
+  // The number of times that the submit button was delayed.
+  int submit_button_delay_number_;
+
   DISALLOW_COPY_AND_ASSIGN(TestAutofillDialogController);
 };
 
 class TestGeneratedCreditCardBubbleController :
     public GeneratedCreditCardBubbleController {
  public:
   explicit TestGeneratedCreditCardBubbleController(
       content::WebContents* contents)
       : GeneratedCreditCardBubbleController(contents) {
     contents->SetUserData(UserDataKey(), this);
@@ skipping 2039 matching lines @@
 TEST_F(AutofillDialogControllerTest,
        SaveInChromePreferenceRememberedOnSuccess) {
   EXPECT_TRUE(controller()->ShouldSaveInChrome());
   SwitchToAutofill();
   FillCreditCardInputs();
   controller()->GetView()->CheckSaveDetailsLocallyCheckbox(false);
   controller()->OnAccept();
   EXPECT_FALSE(controller()->ShouldSaveInChrome());
 }
 
+TEST_F(AutofillDialogControllerTest, SubmitButtonIsDelayedOnShow) {
+  EXPECT_EQ(1, controller()->get_submit_button_delay_number());

[Evan Stade, 2013/09/05 16:29:44]

nit: instead of having a separate test for this, add this line to the start of
each of the other 3 tests.

[please use gerrit instead, 2013/09/05 18:40:49]

Done.

+}
+
+TEST_F(AutofillDialogControllerTest,
+       SubmitButtonIsDisabled_SpinnerFinishesBeforeDelay) {
+  // Begin the submit button delay.
+  controller()->SimulateSubmitButtonDelayBegin();
+
+  EXPECT_TRUE(controller()->ShouldShowSpinner());
+  EXPECT_FALSE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
+
+  // Stop the spinner.
+  controller()->OnDidGetWalletItems(CompleteAndValidWalletItems());
+
+  EXPECT_FALSE(controller()->ShouldShowSpinner());
+  EXPECT_FALSE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
+
+  // End the submit button delay.
+  controller()->SimulateSubmitButtonDelayEnd();
+
+  EXPECT_FALSE(controller()->ShouldShowSpinner());
+  EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
+}
+
+TEST_F(AutofillDialogControllerTest,
+       SubmitButtonIsDisabled_SpinnerFinishesAfterDelay) {
+  // Begin the submit button delay.
+  controller()->SimulateSubmitButtonDelayBegin();
+
+  EXPECT_TRUE(controller()->ShouldShowSpinner());
+  EXPECT_FALSE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
+
+  // End the submit button delay.
+  controller()->SimulateSubmitButtonDelayEnd();
+
+  EXPECT_TRUE(controller()->ShouldShowSpinner());
+  EXPECT_FALSE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
+
+  // Stop the spinner.
+  controller()->OnDidGetWalletItems(CompleteAndValidWalletItems());
+
+  EXPECT_FALSE(controller()->ShouldShowSpinner());
+  EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
+}
+
+TEST_F(AutofillDialogControllerTest, SubmitButtonIsDisabled_NoSpinner) {
+  // Begin the submit button delay.
+  controller()->SimulateSubmitButtonDelayBegin();
+
+  EXPECT_TRUE(controller()->ShouldShowSpinner());
+  EXPECT_FALSE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
+
+  // There's no spinner in Autofill mode.
+  SwitchToAutofill();
+
+  EXPECT_FALSE(controller()->ShouldShowSpinner());
+  EXPECT_FALSE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
+
+  // End the submit button delay.
+  controller()->SimulateSubmitButtonDelayEnd();
+
+  EXPECT_FALSE(controller()->ShouldShowSpinner());
+  EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
+}
+
 }  // namespace autofill