Disable submit button briefly when launching rAc dialog

chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
 
 #include <algorithm>
 #include <map>
 #include <string>
 
@@ skipping 96 matching lines @@
 // WebDB, and hence should not be modified, so that it remains consistent over
 // time.
 const char kAutofillDialogOrigin[] = "Chrome Autofill dialog";
 
 // HSL shift to gray out an image.
 const color_utils::HSL kGrayImageShift = {-1, 0, 0.8};
 
 // Limit Wallet items refresh rate to at most once per minute.
 const int kWalletItemsRefreshRateSeconds = 60;
 
+// The number of milliseconds to delay enabling the submit button after showing
+// the dialog. This delay prevents users from accidentally clicking the submit
+// button on startup.
+const int kSubmitButtonDelayMs = 1000;
+
 // A helper class to make sure an AutofillDialogView knows when a series of
 // updates is incoming.
 class ScopedViewUpdates {
  public:
   explicit ScopedViewUpdates(AutofillDialogView* view) : view_(view) {
     if (view_)
       view_->UpdatesStarted();
   }
 
   ~ScopedViewUpdates() {
@@ skipping 517 matching lines @@
 
   // Try to see if the user is already signed-in. If signed-in, fetch the user's
   // Wallet data. Otherwise, see if the user could be signed in passively.
   // TODO(aruslan): UMA metrics for sign-in.
   signin_helper_.reset(new wallet::WalletSigninHelper(
       this, profile_->GetRequestContext()));
   signin_helper_->StartWalletCookieValueFetch();
 
   if (!account_chooser_model_.WalletIsSelected())
     LogDialogLatencyToShow();
+
+  SubmitButtonDelayBegin(kSubmitButtonDelayMs);

[Evan Stade, 2013/09/04 21:42:52]

I think you should do this before view_->Show()

[please use gerrit instead, 2013/09/05 02:30:58]

Moved up before view_->Show().

 }
 
 void AutofillDialogControllerImpl::Hide() {
   if (view_)
     view_->Hide();
 }
 
 void AutofillDialogControllerImpl::TabActivated() {
   // If the user switched away from this tab and then switched back, reload the
   // Wallet items, in case they've changed.
@@ skipping 92 matching lines @@
 
 bool AutofillDialogControllerImpl::IsDialogButtonEnabled(
     ui::DialogButton button) const {
   if (button == ui::DIALOG_BUTTON_OK) {
     if (IsSubmitPausedOn(wallet::VERIFY_CVV))
       return true;
 
     if (ShouldShowSpinner() || is_submitting_)
       return false;
 
+    if (submit_buton_delay_timer_.IsRunning())
+      return false;
+
     return true;
   }
 
   DCHECK_EQ(ui::DIALOG_BUTTON_CANCEL, button);
   return !is_submitting_ || IsSubmitPausedOn(wallet::VERIFY_CVV);
 }
 
 DialogOverlayState AutofillDialogControllerImpl::GetDialogOverlay() const {
   bool show_wallet_interstitial = IsPayingWithWallet() && is_submitting_ &&
       !IsSubmitPausedOn(wallet::VERIFY_CVV) &&
@@ skipping 1457 matching lines @@
 void AutofillDialogControllerImpl::ShowNewCreditCardBubble(
     scoped_ptr<CreditCard> new_card,
     scoped_ptr<AutofillProfile> billing_profile) {
 #if !defined(OS_ANDROID)
   NewCreditCardBubbleController::Show(profile(),
                                       new_card.Pass(),
                                       billing_profile.Pass());
 #endif
 }
 
+void AutofillDialogControllerImpl::SubmitButtonDelayBegin(int delay_ms) {
+  submit_buton_delay_timer_.Start(
+      FROM_HERE,
+      base::TimeDelta::FromMilliseconds(delay_ms),
+      this,
+      &AutofillDialogControllerImpl::OnSubmitButtonDelayEnd);
+}
+
+void AutofillDialogControllerImpl::OnSubmitButtonDelayEnd() {
+  if (submit_buton_delay_timer_.IsRunning())

[Evan Stade, 2013/09/04 21:42:52]

I dislike this because it shouldn't happen outside of testing, and that's not
obvious here.

[please use gerrit instead, 2013/09/05 02:30:58]

Removed the timer check from OnSubmitButtonDelayEnd(). Added a method
SubmitButtonDelayEndForTesting() that stops the timer and then calls its
OnSubmitButtonDelayEnd() callback.

+    submit_buton_delay_timer_.Stop();
+  if (view_) {
+    ScopedViewUpdates updates(view_.get());
+    view_->UpdateButtonStrip();
+  }
+}
+
 AutofillDialogControllerImpl::AutofillDialogControllerImpl(
     content::WebContents* contents,
     const FormData& form_structure,
     const GURL& source_url,
     const DialogType dialog_type,
     const base::Callback<void(const FormStructure*,
                               const std::string&)>& callback)
     : WebContentsObserver(contents),
       profile_(Profile::FromBrowserContext(contents->GetBrowserContext())),
       initial_user_state_(AutofillMetrics::DIALOG_USER_STATE_UNKNOWN),
@@ skipping 1104 matching lines @@
   }
 #if !defined(OS_ANDROID)
   GeneratedCreditCardBubbleController::Show(
       web_contents(),
       full_wallet_->TypeAndLastFourDigits(),
       backing_last_four);
 #endif
 }
 
 }  // namespace autofill