Disable submit button briefly when launching rAc dialog

chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
 
 #include <algorithm>
 #include <map>
 #include <string>
 
@@ skipping 94 matching lines @@
 // WebDB, and hence should not be modified, so that it remains consistent over
 // time.
 const char kAutofillDialogOrigin[] = "Chrome Autofill dialog";
 
 // HSL shift to gray out an image.
 const color_utils::HSL kGrayImageShift = {-1, 0, 0.8};
 
 // Limit Wallet items refresh rate to at most once per minute.
 const int kWalletItemsRefreshRateSeconds = 60;
 
+// The number of seconds to delay enabling the submit button after showing the
+// dialog. This delay prevents users from accidentally clicking the submit
+// button on startup.
+const int kSubmitButtonDelaySeconds = 1;
+
 // A helper class to make sure an AutofillDialogView knows when a series of
 // updates is incoming.
 class ScopedViewUpdates {
  public:
   explicit ScopedViewUpdates(AutofillDialogView* view) : view_(view) {
     if (view_)
       view_->UpdatesStarted();
   }
 
   ~ScopedViewUpdates() {
@@ skipping 507 matching lines @@
 
   // Try to see if the user is already signed-in. If signed-in, fetch the user's
   // Wallet data. Otherwise, see if the user could be signed in passively.
   // TODO(aruslan): UMA metrics for sign-in.
   signin_helper_.reset(new wallet::WalletSigninHelper(
       this, profile_->GetRequestContext()));
   signin_helper_->StartWalletCookieValueFetch();
 
   if (!account_chooser_model_.WalletIsSelected())
     LogDialogLatencyToShow();
+
+  SubmitButtonDelayBegin();
 }
 
 void AutofillDialogControllerImpl::Hide() {
   if (view_)
     view_->Hide();
 }
 
 void AutofillDialogControllerImpl::TabActivated() {
   // If the user switched away from this tab and then switched back, reload the
   // Wallet items, in case they've changed.
@@ skipping 100 matching lines @@
 
 bool AutofillDialogControllerImpl::IsDialogButtonEnabled(
     ui::DialogButton button) const {
   if (button == ui::DIALOG_BUTTON_OK) {
     if (IsSubmitPausedOn(wallet::VERIFY_CVV))
       return true;
 
     if (ShouldShowSpinner() || is_submitting_)
       return false;
 
+    if (is_submit_button_delayed_)
+      return false;
+
     return true;
   }
 
   DCHECK_EQ(ui::DIALOG_BUTTON_CANCEL, button);
   return !is_submitting_ || IsSubmitPausedOn(wallet::VERIFY_CVV);
 }
 
 DialogOverlayState AutofillDialogControllerImpl::GetDialogOverlay() const {
   bool show_wallet_interstitial = IsPayingWithWallet() && is_submitting_ &&
       !IsSubmitPausedOn(wallet::VERIFY_CVV) &&
@@ skipping 1450 matching lines @@
 void AutofillDialogControllerImpl::ShowNewCreditCardBubble(
     scoped_ptr<CreditCard> new_card,
     scoped_ptr<AutofillProfile> billing_profile) {
 #if !defined(OS_ANDROID)
   NewCreditCardBubbleController::Show(profile(),
                                       new_card.Pass(),
                                       billing_profile.Pass());
 #endif
 }
 
+void AutofillDialogControllerImpl::SubmitButtonDelayBegin() {
+  is_submit_button_delayed_ = true;

[Evan Stade, 2013/09/04 02:36:28]

I think this will be slightly cleaner if you use a Timer

[please use gerrit instead, 2013/09/04 02:51:46]

I can see using a Timer instead of PostDelayedTask, but you seem to have
commented on the is_submit_button_delayed variable. Was that intentional?

[Evan Stade, 2013/09/04 18:24:29]

just because it was the first line of this fn (also you wouldn't need to have
this variable any more)

+  content::BrowserThread::PostDelayedTask(
+      content::BrowserThread::UI,
+      FROM_HERE,
+      base::Bind(&AutofillDialogControllerImpl::OnSubmitButtonDelayEnd,
+                 weak_ptr_factory_.GetWeakPtr()),
+      base::TimeDelta::FromSeconds(kSubmitButtonDelaySeconds));
+}
+
+void AutofillDialogControllerImpl::OnSubmitButtonDelayEnd() {
+  is_submit_button_delayed_ = false;
+  if (view_) {
+    ScopedViewUpdates updates(view_.get());
+    view_->UpdateButtonStrip();
+  }
+}
+
 AutofillDialogControllerImpl::AutofillDialogControllerImpl(
     content::WebContents* contents,
     const FormData& form_structure,
     const GURL& source_url,
     const DialogType dialog_type,
     const base::Callback<void(const FormStructure*,
                               const std::string&)>& callback)
     : WebContentsObserver(contents),
       profile_(Profile::FromBrowserContext(contents->GetBrowserContext())),
       initial_user_state_(AutofillMetrics::DIALOG_USER_STATE_UNKNOWN),
@@ skipping 14 matching lines @@
       input_showing_popup_(NULL),
       weak_ptr_factory_(this),
       should_show_wallet_promo_(!profile_->GetPrefs()->GetBoolean(
           ::prefs::kAutofillDialogHasPaidWithWallet)),
       has_shown_wallet_usage_confirmation_(false),
       has_accepted_legal_documents_(false),
       is_submitting_(false),
       choose_another_instrument_or_address_(false),
       wallet_server_validation_recoverable_(true),
       data_was_passed_back_(false),
-      was_ui_latency_logged_(false) {
+      was_ui_latency_logged_(false),
+      is_submit_button_delayed_(false) {
   // TODO(estade): remove duplicates from |form_structure|?
   DCHECK(!callback_.is_null());
 }
 
 AutofillDialogView* AutofillDialogControllerImpl::CreateView() {
   return AutofillDialogView::Create(this);
 }
 
 PersonalDataManager* AutofillDialogControllerImpl::GetManager() {
   return PersonalDataManagerFactory::GetForProfile(profile_);
@@ skipping 1063 matching lines @@
   }
 #if !defined(OS_ANDROID)
   GeneratedCreditCardBubbleController::Show(
       web_contents(),
       full_wallet_->TypeAndLastFourDigits(),
       backing_last_four);
 #endif
 }
 
 }  // namespace autofill