Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23717027: Media Galleries API Picasa: Move Picasa source files to correct location. (Closed)

Created:
7 years, 3 months ago by tommycli
Modified:
7 years, 3 months ago
CC:
chromium-reviews, Lei Zhang, tzik+watch_chromium.org, tommycli, Greg Billock, kinuko+watch
Visibility:
Public.

Description

Media Galleries API Picasa: Move Picasa source files to correct location. Depends on: https://codereview.chromium.org/23499006/ R=vandebo BUG=151701 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221863

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2157 lines) Patch
M chrome/browser/media_galleries/fileapi/media_file_system_backend.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/media_galleries/fileapi/picasa/picasa_data_provider.h View 1 chunk +0 lines, -121 lines 0 comments Download
D chrome/browser/media_galleries/fileapi/picasa/picasa_data_provider.cc View 1 2 1 chunk +0 lines, -266 lines 0 comments Download
D chrome/browser/media_galleries/fileapi/picasa/picasa_data_provider_browsertest.cc View 1 1 chunk +0 lines, -599 lines 0 comments Download
D chrome/browser/media_galleries/fileapi/picasa/picasa_file_util.h View 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/browser/media_galleries/fileapi/picasa/picasa_file_util.cc View 1 chunk +0 lines, -373 lines 0 comments Download
D chrome/browser/media_galleries/fileapi/picasa/picasa_file_util_unittest.cc View 1 chunk +0 lines, -600 lines 0 comments Download
D chrome/browser/media_galleries/fileapi/picasa/picasa_finder.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/media_galleries/fileapi/picasa/picasa_finder.cc View 1 1 chunk +0 lines, -66 lines 0 comments Download
A + chrome/browser/media_galleries/fileapi/picasa_data_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media_galleries/fileapi/picasa_data_provider.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media_galleries/fileapi/picasa_data_provider_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media_galleries/fileapi/picasa_file_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media_galleries/fileapi/picasa_file_util.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/media_galleries/fileapi/picasa_file_util_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/media_galleries/fileapi/picasa_finder.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media_galleries/fileapi/picasa_finder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/imported_media_gallery_registry.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tommycli
vandebo: No rush, just the 'move'.
7 years, 3 months ago (2013-09-03 20:35:55 UTC) #1
vandebo (ex-Chrome)
https://codereview.chromium.org/23717027/diff/1/chrome/browser/media_galleries/fileapi/picasa_data_provider.cc File chrome/browser/media_galleries/fileapi/picasa_data_provider.cc (right): https://codereview.chromium.org/23717027/diff/1/chrome/browser/media_galleries/fileapi/picasa_data_provider.cc#newcode5 chrome/browser/media_galleries/fileapi/picasa_data_provider.cc:5: #include "chrome/browser/media_galleries/fileapi/picasa/picasa_data_provider.h" extra picassa - Looks like you didn't ...
7 years, 3 months ago (2013-09-05 16:56:27 UTC) #2
tommycli
https://codereview.chromium.org/23717027/diff/1/chrome/browser/media_galleries/fileapi/picasa_data_provider.cc File chrome/browser/media_galleries/fileapi/picasa_data_provider.cc (right): https://codereview.chromium.org/23717027/diff/1/chrome/browser/media_galleries/fileapi/picasa_data_provider.cc#newcode5 chrome/browser/media_galleries/fileapi/picasa_data_provider.cc:5: #include "chrome/browser/media_galleries/fileapi/picasa/picasa_data_provider.h" On 2013/09/05 16:56:28, vandebo wrote: > extra ...
7 years, 3 months ago (2013-09-06 00:22:14 UTC) #3
vandebo (ex-Chrome)
LGTM
7 years, 3 months ago (2013-09-06 15:28:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/23717027/32001
7 years, 3 months ago (2013-09-06 23:46:47 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-07 02:33:15 UTC) #6
Message was sent while issue was closed. 
Change committed as 221863

Powered by Google App Engine
This is Rietveld 408576698