Add stubs for brailleDisplayPrivate extension API.

chrome/browser/extensions/api/braille_display_private/braille_display_private_api.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_API_BRAILLE_DISPLAY_PRIVATE_BRAILLE_DISPLAY_PRIVATE_API_H_
+#define CHROME_BROWSER_EXTENSIONS_API_BRAILLE_DISPLAY_PRIVATE_BRAILLE_DISPLAY_PRIVATE_API_H_
+
+#include "chrome/browser/extensions/api/api_function.h"
+#include "chrome/browser/extensions/api/profile_keyed_api_factory.h"
+#include "chrome/common/extensions/api/braille_display_private.h"
+
+namespace extensions {
+

[not at google - send to devlin, 2013/09/03 14:35:35]

Comment; but can be "implementation of the chrome.brailleDisplayPrivate API".

[Peter Lundblad, 2013/09/03 23:03:34]

Done.

+class BrailleDisplayPrivateAPI : public ProfileKeyedAPI {
+ public:
+  explicit BrailleDisplayPrivateAPI(Profile* profile);
+  virtual ~BrailleDisplayPrivateAPI();
+
+  // ProfileKeyedService implementation.
+  virtual void Shutdown() OVERRIDE;
+
+  // ProfileKeyedAPI implementation.
+  static ProfileKeyedAPIFactory<BrailleDisplayPrivateAPI>* GetFactoryInstance();
+
+ private:
+  friend class ProfileKeyedAPIFactory<BrailleDisplayPrivateAPI>;
+
+  Profile* profile_;
+
+  // ProfileKeyedAPI implementation.
+  static const char* service_name() {
+    return "BrailleDisplayPrivateAPI";
+  }
+  static const bool kServiceIsNULLWhileTesting = true;
+};
+
+namespace api {
+class BrailleDisplayPrivateGetDisplayStateFunction : public AsyncApiFunction {

[not at google - send to devlin, 2013/09/03 14:35:35]

the "AsyncApiFunction" class is for extension functions implemented cross-thread
(typically IO vs UI). is that the situation that the braille devices need?

[Peter Lundblad, 2013/09/03 23:03:34]

The API uses a library that communicates with a deamon over a local socket. I
thought the IO thread would be good for that (the communication is nonblocking).
Since getting the display state (size in particular) potentially calls the
daemon, this should happen on the IO thread I think.

[not at google - send to devlin, 2013/09/03 23:40:18]

ok sounds good.

+  DECLARE_EXTENSION_FUNCTION("brailleDisplayPrivate.getDisplayState",
+                             BRAILLEDISPLAYPRIVATE_GETDISPLAYSTATE)
+ protected:
+  virtual ~BrailleDisplayPrivateGetDisplayStateFunction() {}
+  virtual bool Prepare() OVERRIDE;
+  virtual void Work() OVERRIDE;
+  virtual bool Respond() OVERRIDE;
+};
+
+class BrailleDisplayPrivateWriteDotsFunction : public AsyncApiFunction {
+  DECLARE_EXTENSION_FUNCTION("brailleDisplayPrivate.writeDots",
+                             BRAILLEDISPLAYPRIVATE_WRITEDOTS)
+  public:

[not at google - send to devlin, 2013/09/03 14:35:35]

ideally, 1 less indent space here, and a line break between the public,
protected, and private blocks.

[Peter Lundblad, 2013/09/03 23:03:34]

Done.

+  BrailleDisplayPrivateWriteDotsFunction();
+ protected:
+  virtual ~BrailleDisplayPrivateWriteDotsFunction();
+  virtual bool Prepare() OVERRIDE;
+  virtual void Work() OVERRIDE;
+  virtual bool Respond() OVERRIDE;
+ private:
+  scoped_ptr<braille_display_private::WriteDots::Params> params_;
+};

[not at google - send to devlin, 2013/09/03 14:35:35]

and a line break here

[Peter Lundblad, 2013/09/03 23:03:34]

Done.

+}  // namespace api
+}  // namespace extensions

[not at google - send to devlin, 2013/09/03 14:35:35]

and after here

[Peter Lundblad, 2013/09/03 23:03:34]

Done.

+#endif  // CHROME_BROWSER_EXTENSIONS_API_BRAILLE_DISPLAY_PRIVATE_BRAILLE_DISPLAY_PRIVATE_API_H_