Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issue 23717009: Improve feature detection. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Improve feature detection. Add V8_GLIBC_PREREQ() macro to test the version of the GNU C library. Make V8_GNUC_PREREQ() work for compilers that masquerade as GCC (you can always use V8_CC_* to test for a specific one if you need to). Add V8_LIBC_* to detect the C library in use. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16450

Patch Set 1 #

Patch Set 2 : Style fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -9 lines) Patch
M include/v8config.h View 1 5 chunks +72 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
7 years, 3 months ago (2013-08-30 11:47:43 UTC) #1
Sven Panne
lgtm
7 years, 3 months ago (2013-08-30 12:09:05 UTC) #2
Benedikt Meurer
7 years, 3 months ago (2013-08-30 12:09:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16450 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698