[Files.app] Refinement events of suggest app dialog

chrome/browser/resources/file_manager/js/cws_container_client.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @param {WebView} webView Web View tag.
  * @param {string} ext File extension.
  * @param {string} mime File mime type.
@@ skipping 29 matching lines @@
  * @param {Event} event Message event.
  * @private
  */
 CWSContainerClient.prototype.onMessage_ = function(event) {
   if (event.origin != this.target_)
     return;
 
   var data = event.data;
   switch (data['message']) {
     case 'widget_loaded':
-      // Do nothing. Waits for user action and next message.
+      this.onWidgetLoaded_();
+      break;
+    case 'widget_load_failed':
+      this.onWidgetLoadFailed_();
       break;
     case 'before_install':
       this.sendInstallRequest_(data['item_id']);
       break;
     default:
       console.error('Unexpected message: ' + data['message'], data);
   }
 };
 
 /**
  * Called when receiving 'loadstop' event from the <wevview>.
  * @param {Event} event Message event.
  * @private
  */
 CWSContainerClient.prototype.onLoadStop_ = function(event) {
   if (this.url_ == this.webView_.src && !this.loaded_) {
     this.loaded_ = true;
     this.postInitializeMessage_();
   }
 };
 
 /**
+ * Called when the widget is loaded successfully.
+ * @private
+ */
+CWSContainerClient.prototype.onWidgetLoaded_ = function() {
+  this.dispatchEvent(new cr.Event('loaded'));

[hirono, 2013/08/30 09:06:19]

Can we make the event names enum values?
To do this, we can obtain the space where to describe the detailed comments for
the events.

[yoshiki, 2013/08/30 09:16:03]

Done.

+};
+
+/**
+ * Called when the widget is failed to load.
+ * @private
+ */
+CWSContainerClient.prototype.onWidgetLoadFailed_ = function() {
+  this.sendWidgetLoadFailed_();
+};
+
+/**
  * Called when receiving the 'loadabort' event from <webview>.
  * @param {Event} event Message event.
  * @private
  */
 CWSContainerClient.prototype.onLoadAbort_ = function(event) {
-  this.sendWebviewLoadAbort_();
+  this.sendWidgetLoadFailed_();
 };
 
 /**
  * Called when the installation is completed from the suggest-app dialog.
  *
  * @param {boolean} result True if the installation is success, false if failed.
  * @param {string} itemId Item id to be installed.
  */
 CWSContainerClient.prototype.onInstallCompleted = function(result, itemId) {
   if (result)
     this.postInstallSuccessMessage_(itemId);
   else
     this.postInstallFailureMessage_(itemId);
 };
 
 /**
- * Send the abort event to the suggest-app dialog.
+ * Send the fail message to the suggest-app dialog.
  * @private
  */
-CWSContainerClient.prototype.sendWebviewLoadAbort_ = function() {
-  this.dispatchEvent(new cr.Event('webview-load-abort'));
+CWSContainerClient.prototype.sendWidgetLoadFailed_ = function() {
+  this.dispatchEvent(new cr.Event('load-failed'));
 };
 
 /**
  * Send the install request to the suggest-app dialog.
  *
  * @param {string} itemId Item id to be installed.
  * @private
  */
 CWSContainerClient.prototype.sendInstallRequest_ = function(itemId) {
   var event = new cr.Event('install-request');
@@ skipping 91 matching lines @@
   this.webView_.stop();
 };
 
 /**
  * Cleans the dialog by removing all handlers.
  */
 CWSContainerClient.prototype.dispose = function() {
   this.abort();
 };