Not remove a pinned notification by user action

Not remove a pinned notification by user action

The pinned notification should be unremovable by user action, but it was removable by delete key. This patch fixes the issue by making pinned notifications unremovable by user action.

BUG=647149
TEST=manual test

Committed: https://crrev.com/d78edc6840a9a42afc7b50e6e714b9fc21f0c6d8
Cr-Commit-Position: refs/heads/master@{#422092}

[yoshiki, 2016-09-26 08:54:14]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 08:54:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 10:04:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 10:04:28]

Dry run: This issue passed the CQ dry run.

[yoshiki, 2016-09-28 19:16:01]

Description was changed from

==========
.

BUG=
==========

to

==========
Not remove a pinned notification by user action

The pinned notification should be unremovable by user action, but it was
removable by delete key. This patch fixes the issue by making pinned
notifications unremovable by user action.

BUG=647149
TEST=manual test
==========

[yoshiki, 2016-09-28 19:16:02]

yoshiki@chromium.org changed reviewers:
+ xiyuan@chromium.org

[yoshiki, 2016-09-28 19:16:13]

Xiyuan, PTAL. Thanks.

[xiyuan, 2016-09-28 19:27:41]

lgtm

https://codereview.chromium.org/2371693002/diff/1/ui/message_center/message_c...
File ui/message_center/message_center_impl.cc (right):

https://codereview.chromium.org/2371693002/diff/1/ui/message_center/message_c...
ui/message_center/message_center_impl.cc:619: message_center::Notification*
notification = FindVisibleNotificationById(id);
nit: "message_center::" is not necessary.

[yoshiki, 2016-09-30 04:55:38]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 04:55:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoshiki, 2016-09-30 04:56:10]

https://codereview.chromium.org/2371693002/diff/1/ui/message_center/message_c...
File ui/message_center/message_center_impl.cc (right):

https://codereview.chromium.org/2371693002/diff/1/ui/message_center/message_c...
ui/message_center/message_center_impl.cc:619: message_center::Notification*
notification = FindVisibleNotificationById(id);
On 2016/09/28 19:27:40, xiyuan wrote:
> nit: "message_center::" is not necessary.

Done.

[commit-bot: I haz the power, 2016-09-30 05:56:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 05:56:29]

Dry run: This issue passed the CQ dry run.

[yoshiki, 2016-09-30 12:52:18]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2016-09-30 12:52:18]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2371693002/#ps20001
(title: "Addressed the nit.")

[commit-bot: I haz the power, 2016-09-30 12:52:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 12:57:08]

Description was changed from

==========
Not remove a pinned notification by user action

The pinned notification should be unremovable by user action, but it was
removable by delete key. This patch fixes the issue by making pinned
notifications unremovable by user action.

BUG=647149
TEST=manual test
==========

to

==========
Not remove a pinned notification by user action

The pinned notification should be unremovable by user action, but it was
removable by delete key. This patch fixes the issue by making pinned
notifications unremovable by user action.

BUG=647149
TEST=manual test
==========

[commit-bot: I haz the power, 2016-09-30 12:57:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-30 12:58:32]

Description was changed from

==========
Not remove a pinned notification by user action

The pinned notification should be unremovable by user action, but it was
removable by delete key. This patch fixes the issue by making pinned
notifications unremovable by user action.

BUG=647149
TEST=manual test
==========

to

==========
Not remove a pinned notification by user action

The pinned notification should be unremovable by user action, but it was
removable by delete key. This patch fixes the issue by making pinned
notifications unremovable by user action.

BUG=647149
TEST=manual test

Committed: https://crrev.com/d78edc6840a9a42afc7b50e6e714b9fc21f0c6d8
Cr-Commit-Position: refs/heads/master@{#422092}
==========

[commit-bot: I haz the power, 2016-09-30 12:58:33]

Patchset 2 (id:??) landed as
https://crrev.com/d78edc6840a9a42afc7b50e6e714b9fc21f0c6d8
Cr-Commit-Position: refs/heads/master@{#422092}