[CSS Typed OM] Implement support for CSSValue -> CSSCalcLength

third_party/WebKit/Source/core/css/CSSCalculationValue.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 234 matching lines @@
       return false;
 
     return compareCSSValuePtr(
         m_value, static_cast<const CSSCalcPrimitiveValue&>(other).m_value);
   }
 
   Type getType() const override { return CssCalcPrimitiveValue; }
   CSSPrimitiveValue::UnitType typeWithCalcResolved() const override {
     return m_value->typeWithCalcResolved();
   }
+  const CSSCalcExpressionNode* leftExpressionNode() const { return nullptr; }
+
+  const CSSCalcExpressionNode* rightExpressionNode() const { return nullptr; }
+
+  CalcOperator operatorType() const { return CalcAdd; }

[alancutter (OOO until 2018), 2016/10/13 22:19:05]

Can these just be NOTREACHED()?

[meade_UTC10, 2016/11/16 19:28:21]

Done.

 
   DEFINE_INLINE_VIRTUAL_TRACE() {
     visitor->trace(m_value);
     CSSCalcExpressionNode::trace(visitor);
   }
 
  private:
   CSSCalcPrimitiveValue(CSSPrimitiveValue* value, bool isInteger)
       : CSSCalcExpressionNode(unitCategory(value->typeWithCalcResolved()),
                               isInteger),
@@ skipping 279 matching lines @@
       return false;
 
     const CSSCalcBinaryOperation& other =
         static_cast<const CSSCalcBinaryOperation&>(exp);
     return compareCSSValuePtr(m_leftSide, other.m_leftSide) &&
            compareCSSValuePtr(m_rightSide, other.m_rightSide) &&
            m_operator == other.m_operator;
   }
 
   Type getType() const override { return CssCalcBinaryOperation; }
+  const CSSCalcExpressionNode* leftExpressionNode() const { return m_leftSide; }
+
+  const CSSCalcExpressionNode* rightExpressionNode() const {
+    return m_rightSide;
+  }
+
+  CalcOperator operatorType() const { return m_operator; }
 
   CSSPrimitiveValue::UnitType typeWithCalcResolved() const override {
     switch (m_category) {
       case CalcNumber:
         ASSERT(m_leftSide->category() == CalcNumber &&
                m_rightSide->category() == CalcNumber);
         return CSSPrimitiveValue::UnitType::Number;
       case CalcLength:
       case CalcPercent: {
         if (m_leftSide->category() == CalcNumber)
@@ skipping 248 matching lines @@
 
   return expression ? new CSSCalcValue(expression, range) : nullptr;
 }
 
 CSSCalcValue* CSSCalcValue::create(CSSCalcExpressionNode* expression,
                                    ValueRange range) {
   return new CSSCalcValue(expression, range);
 }
 
 }  // namespace blink