Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2371663002: Introduce an injection point to configure the internal pointer of WeakPtr

Created:
4 years, 2 months ago by tzik
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, gavinp+memory_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce an injection point to configure the internal pointer of WeakPtr BUG=

Patch Set 1 #

Patch Set 2 : +static_assert #

Patch Set 3 : fix #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+390 lines, -298 lines) Patch
M base/memory/weak_ptr.h View 1 2 3 8 chunks +92 lines, -62 lines 0 comments Download
M base/memory/weak_ptr_unittest.nc View 6 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverController.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MainThreadTaskRunner.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h View 1 2 3 2 chunks +183 lines, -184 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 1 2 3 5 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/CrossThreadCopier.h View 1 2 3 3 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Persistent.h View 1 2 3 3 chunks +68 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/WeakPtr.h View 1 2 3 1 chunk +17 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (8 generated)
tzik
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-09-27 08:51:10 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371663002/40001
4 years, 2 months ago (2016-09-27 08:51:24 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-09-27 10:02:25 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/148860)
4 years, 2 months ago (2016-09-27 10:02:26 UTC) #4
tzik
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-09-28 13:48:00 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371663002/60001
4 years, 2 months ago (2016-09-28 13:48:13 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-09-28 14:33:37 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 14:33:38 UTC) #8 
Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

Powered by Google App Engine
This is Rietveld 408576698