Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2371643002: HTMLImageElement: do not use fallback content for ImageDocument (Closed)

Created:
4 years, 2 months ago by hiroshige
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2840
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

HTMLImageElement: do not use fallback content for ImageDocument After https://codereview.chromium.org/1879793003, ImageLoader::hasPendingActivity() became false for ImageDocument and thus HTMLImageElement::selectSourceURL() didn't consider the image as still loading during load (|imageStillLoading| became false). This caused ImageDocument not to be displayed progressively. This CL makes HTMLImageElement to use primary content for ImageDocument. This causes ImageDocument not to be replaced with fallback content, but I expect that is more acceptable than images not displayed progressively. BUG=632495 Review-Url: https://codereview.chromium.org/2343613002 Cr-Commit-Position: refs/heads/master@{#420432} (cherry picked from commit c5e43f7edf4e55155fcda51be0285f37b20c2e76) Committed: https://chromium.googlesource.com/chromium/src/+/01e1c1571cd16ec4f3ff0342f8f1e0f943cd942f

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
hiroshige
4 years, 2 months ago (2016-09-26 05:16:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
01e1c1571cd16ec4f3ff0342f8f1e0f943cd942f.

Powered by Google App Engine
This is Rietveld 408576698