Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2371513002: Lint suppressions needed for Android SDK roll. (Closed)

Created:
4 years, 2 months ago by ghost stip (do not use)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Lint suppressions needed for Android SDK roll. This is only part of the suppressions needed for a full compile, I'm splitting them up into separate CLs to make OWNERS review easier. BUG=623989 R=jbudorick@chromium.org, dtrainor@chromium.org Committed: https://crrev.com/9d43e73df37649c6e82aa0b05ace70eca1a6898f Cr-Commit-Position: refs/heads/master@{#421028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ghost stip (do not use)
jbudorick: ptal dtrainor: OWNERS
4 years, 2 months ago (2016-09-23 23:23:17 UTC) #1
jbudorick
lgtm
4 years, 2 months ago (2016-09-24 03:38:56 UTC) #2
David Trainor- moved to gerrit
lgtm sorry for the delay
4 years, 2 months ago (2016-09-26 18:47:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371513002/1
4 years, 2 months ago (2016-09-26 21:51:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 22:53:10 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 22:54:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d43e73df37649c6e82aa0b05ace70eca1a6898f
Cr-Commit-Position: refs/heads/master@{#421028}

Powered by Google App Engine
This is Rietveld 408576698