Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: blimp/client/core/feedback/blimp_feedback_data_unittest.cc

Issue 2371503002: Add Blimp feedback data about visible BlimpContents. (Closed)
Patch Set: Rebased for good measure Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/core/feedback/blimp_feedback_data.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/core/feedback/blimp_feedback_data_unittest.cc
diff --git a/blimp/client/core/feedback/blimp_feedback_data_unittest.cc b/blimp/client/core/feedback/blimp_feedback_data_unittest.cc
index 16790dc8fceef8f51f034e934bafd3ae77321cfb..1542a93410b2ecc6e1002619f7f506702bcfcd44 100644
--- a/blimp/client/core/feedback/blimp_feedback_data_unittest.cc
+++ b/blimp/client/core/feedback/blimp_feedback_data_unittest.cc
@@ -4,19 +4,99 @@
#include "blimp/client/core/feedback/blimp_feedback_data.h"
+#include "base/memory/ptr_util.h"
+#include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
+#include "blimp/client/core/compositor/blimp_compositor_dependencies.h"
+#include "blimp/client/core/contents/blimp_contents_impl.h"
+#include "blimp/client/core/contents/blimp_contents_manager.h"
+#include "blimp/client/core/contents/ime_feature.h"
+#include "blimp/client/core/contents/tab_control_feature.h"
+#include "blimp/client/core/render_widget/render_widget_feature.h"
+#include "blimp/client/test/compositor/mock_compositor_dependencies.h"
+#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/gfx/native_widget_types.h"
+
+#if defined(OS_ANDROID)
+#include "ui/android/window_android.h"
+#endif // defined(OS_ANDROID)
namespace blimp {
namespace client {
namespace {
-TEST(BlimpFeedbackDataTest, IncludesBlimpIsSupported) {
- std::unordered_map<std::string, std::string> data = CreateBlimpFeedbackData();
+class MockTabControlFeature : public TabControlFeature {
+ public:
+ MockTabControlFeature() {}
+ ~MockTabControlFeature() override = default;
+
+ MOCK_METHOD1(CreateTab, void(int));
+ MOCK_METHOD1(CloseTab, void(int));
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(MockTabControlFeature);
+};
+
+class BlimpFeedbackDataTest : public testing::Test {
+ public:
+ BlimpFeedbackDataTest()
+ : compositor_deps_(base::MakeUnique<MockCompositorDependencies>()),
+ blimp_contents_manager_(&compositor_deps_,
+ &ime_feature_,
+ nullptr,
+ &render_widget_feature_,
+ &tab_control_feature_) {}
+
+#if defined(OS_ANDROID)
+ void SetUp() override { window_ = ui::WindowAndroid::CreateForTesting(); }
+
+ void TearDown() override { window_->DestroyForTesting(); }
+#endif // defined(OS_ANDROID)
+
+ protected:
+ gfx::NativeWindow window_ = nullptr;
+
+ base::MessageLoop loop_;
+ ImeFeature ime_feature_;
+ RenderWidgetFeature render_widget_feature_;
+ MockTabControlFeature tab_control_feature_;
+ BlimpCompositorDependencies compositor_deps_;
+ BlimpContentsManager blimp_contents_manager_;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(BlimpFeedbackDataTest);
+};
+
+TEST_F(BlimpFeedbackDataTest, IncludesBlimpIsSupported) {
+ std::unordered_map<std::string, std::string> data =
+ CreateBlimpFeedbackData(&blimp_contents_manager_);
auto search = data.find(kFeedbackSupportedKey);
ASSERT_TRUE(search != data.end());
EXPECT_EQ("true", search->second);
}
+TEST_F(BlimpFeedbackDataTest, CheckVisibilityCalculation) {
+ EXPECT_CALL(tab_control_feature_, CreateTab(testing::_)).Times(1);
+ std::unique_ptr<BlimpContentsImpl> blimp_contents =
+ blimp_contents_manager_.CreateBlimpContents(window_);
+
+ // Verify that visibility is false when there are no visible BlimpContents.
+ blimp_contents->Hide();
+ std::unordered_map<std::string, std::string> data =
+ CreateBlimpFeedbackData(&blimp_contents_manager_);
+ auto search = data.find(kFeedbackHasVisibleBlimpContents);
+ ASSERT_TRUE(search != data.end());
+ EXPECT_EQ("false", search->second);
+
+ // Verify that visibility is true when there are visible BlimpContents.
+ blimp_contents->Show();
+ data = CreateBlimpFeedbackData(&blimp_contents_manager_);
+ search = data.find(kFeedbackHasVisibleBlimpContents);
+ ASSERT_TRUE(search != data.end());
+ EXPECT_EQ("true", search->second);
+}
+
} // namespace
} // namespace client
} // namespace blimp
« no previous file with comments | « blimp/client/core/feedback/blimp_feedback_data.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698