blimp/client/core/feedback/BUILD.gn - Issue 2371503002: Add Blimp feedback data about visible BlimpContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/feedback/BUILD.gn

Issue 2371503002: Add Blimp feedback data about visible BlimpContents. (Closed)

Patch Set: Rebased for good measure Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/core/feedback/BUILD.gn

diff --git a/blimp/client/core/feedback/BUILD.gn b/blimp/client/core/feedback/BUILD.gn

index 4981e304c032507207226a21e5ff98ebfbcaac39..e154c3cbbdd1a2a8914d6d90755198f08193cbed 100644

--- a/blimp/client/core/feedback/BUILD.gn

+++ b/blimp/client/core/feedback/BUILD.gn

@@ -17,6 +17,7 @@ source_set("feedback") {

deps = [

"//base",

+ "//blimp/client/core/contents",

]

if (is_android) {

@@ -40,6 +41,12 @@ source_set("unit_tests") {

deps = [

":feedback",

+ "//base",

+ "//blimp/client/core/compositor",

+ "//blimp/client/core/contents",

+ "//blimp/client/test/compositor",

+ "//skia",

+ "//testing/gmock",

"//testing/gtest",

]

}