Add Blimp feedback data about visible BlimpContents.

blimp/client/core/contents/blimp_contents_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/client/core/contents/blimp_contents_manager.h"
 
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "blimp/client/core/compositor/blimp_compositor_dependencies.h"
@@ skipping 79 matching lines @@
   BlimpContentsDeletionObserver* observer = observer_map_.at(id).get();
   // If the BlimpContents that the observer tracks is empty, it means
   // OnContentsDestroyed was called on this observer, but the task to erase
   // the observer from the map hasn't been run.
   if (observer->blimp_contents())
     return static_cast<BlimpContentsImpl*>(observer->blimp_contents());
 
   return nullptr;
 }
 
+std::vector<BlimpContentsImpl*>
+BlimpContentsManager::GetAllActiveBlimpContents() {
+  std::vector<BlimpContentsImpl*> all_blimp_contents;
+  for (const auto& item : observer_map_) {
+    all_blimp_contents.push_back(

[David Trainor- moved to gerrit, 2016/09/27 03:49:26]

Check if the contents is null or not.  We do a posttask on removing it from the
map after the destroy call.  So the observer might have a null contents.

[nyquist, 2016/09/27 06:21:29]

Wow! Good catch, thanks! Fixed now. I also of course added a test for this
specific case and verified it fails without the fix, and that the result was as
expected (1 bad entry in return result).

+        static_cast<BlimpContentsImpl*>(item.second.get()->blimp_contents()));
+  }
+  return all_blimp_contents;
+}
+
 int BlimpContentsManager::CreateBlimpContentsId() {
   return next_blimp_contents_id_++;
 }
 
 void BlimpContentsManager::EraseObserverFromMap(int id) {
   observer_map_.erase(id);
 }
 
 void BlimpContentsManager::OnContentsDestroyed(BlimpContents* contents) {
   DCHECK(tab_exists_);
@@ skipping 10 matching lines @@
       FROM_HERE, base::Bind(&BlimpContentsManager::EraseObserverFromMap,
                             this->GetWeakPtr(), id));
 }
 
 base::WeakPtr<BlimpContentsManager> BlimpContentsManager::GetWeakPtr() {
   return weak_ptr_factory_.GetWeakPtr();
 }
 
 }  // namespace client
 }  // namespace blimp