Files.app: Rename the FileBrowserPrivateAPI's functions.

Files.app: Rename the FileBrowserPrivateAPI's functions.

This is required to let the auto-generated codes by scheme compiler refer the
API functions.

BUG=253358
TEST=file_manager_browsertests
R=hashimoto@chromium.org, satorux@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220539

[hirono, 2013-08-30 05:54:16]

Could you take a look the CL?
Thank you very much!

[satorux1, 2013-08-30 05:55:26]

FileBrowserPrivateLGTM

[hashimoto, 2013-08-30 06:03:14]

lgtm with nits

https://codereview.chromium.org/23715003/diff/4001/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
(right):

https://codereview.chromium.org/23715003/diff/4001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc:703:
drive::FileError error, const GURL& share_url) {
nit: These arguments may better be placed in a one per line manner?

https://codereview.chromium.org/23715003/diff/4001/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
(right):

https://codereview.chromium.org/23715003/diff/4001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc:182:
FileBrowserPrivateRequestFileSystemFunction() {
nit: Better indented by 4 spaces? (cf.
https://code.google.com/p/chromium/codesearch#search/&sq=package:chromium&q=%...)
The same goes for others.

[hirono, 2013-08-30 06:26:46]

Thanks!

https://codereview.chromium.org/23715003/diff/4001/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
(right):

https://codereview.chromium.org/23715003/diff/4001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc:703:
drive::FileError error, const GURL& share_url) {
On 2013/08/30 06:03:14, hashimoto wrote:
> nit: These arguments may better be placed in a one per line manner?

Done.

https://codereview.chromium.org/23715003/diff/4001/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
(right):

https://codereview.chromium.org/23715003/diff/4001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc:182:
FileBrowserPrivateRequestFileSystemFunction() {
On 2013/08/30 06:03:14, hashimoto wrote:
> nit: Better indented by 4 spaces? (cf.
>
https://code.google.com/p/chromium/codesearch#search/&sq=package:chromium&q=%...)
> The same goes for others.

Done.

[hashimoto, 2013-08-30 06:30:53]

lgtm

[hirono, 2013-08-30 08:59:13]

Committed patchset #3 manually as r220539 (presubmit successful).