content/browser/indexed_db/indexed_db_database_unittest.cc - Issue 237143006: Make iterating over a corrupted IndexedDB fail.

Unified Diff: content/browser/indexed_db/indexed_db_database_unittest.cc

Issue 237143006: Make iterating over a corrupted IndexedDB fail. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Josh's file set #1 comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/indexed_db_database.cc ('k') | content/browser/indexed_db/indexed_db_dispatcher_host.cc » ('j') | content/browser/indexed_db/indexed_db_transaction_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/indexed_db_database_unittest.cc

diff --git a/content/browser/indexed_db/indexed_db_database_unittest.cc b/content/browser/indexed_db/indexed_db_database_unittest.cc

index 46a26ecf9c1c9e7abbd5dfbf72db628483f4206c..ef916b0e4b347b59f617706ac96a0f7fd95bad9e 100644

--- a/content/browser/indexed_db/indexed_db_database_unittest.cc

+++ b/content/browser/indexed_db/indexed_db_database_unittest.cc

@@ -35,11 +35,13 @@ TEST(IndexedDBDatabaseTest, BackingStoreRetention) {

EXPECT_TRUE(backing_store->HasOneRef());

IndexedDBFactory* factory = 0;

- scoped_refptr<IndexedDBDatabase> db = IndexedDBDatabase::Create(

- ASCIIToUTF16("db"),

- backing_store,

- factory,

- IndexedDBDatabase::Identifier());

+ leveldb::Status s;

+ scoped_refptr<IndexedDBDatabase> db =

+ IndexedDBDatabase::Create(ASCIIToUTF16("db"),

+ backing_store,

+ factory,

+ IndexedDBDatabase::Identifier(),

+ &s);

EXPECT_FALSE(backing_store->HasOneRef()); // local and db

db = NULL;

EXPECT_TRUE(backing_store->HasOneRef()); // local

@@ -51,11 +53,13 @@ TEST(IndexedDBDatabaseTest, ConnectionLifecycle) {

EXPECT_TRUE(backing_store->HasOneRef()); // local

IndexedDBFactory* factory = 0;

+ leveldb::Status s;

scoped_refptr<IndexedDBDatabase> db =

IndexedDBDatabase::Create(ASCIIToUTF16("db"),

backing_store,

factory,

- IndexedDBDatabase::Identifier());

+ IndexedDBDatabase::Identifier(),

+ &s);

jsbell 2014/04/15 16:39:57 Can you toss in ASSERT(s.ok()) after these calls?

cmumford 2014/04/15 17:34:37 Assumed you meant gtest's ASSERT_TRUE - done.

EXPECT_FALSE(backing_store->HasOneRef()); // local and db

@@ -107,11 +111,13 @@ TEST(IndexedDBDatabaseTest, ForcedClose) {

EXPECT_TRUE(backing_store->HasOneRef());

IndexedDBFactory* factory = 0;

+ leveldb::Status s;

scoped_refptr<IndexedDBDatabase> database =

IndexedDBDatabase::Create(ASCIIToUTF16("db"),

backing_store,

factory,

- IndexedDBDatabase::Identifier());

+ IndexedDBDatabase::Identifier(),

+ &s);

EXPECT_FALSE(backing_store->HasOneRef()); // local and db

@@ -168,11 +174,13 @@ TEST(IndexedDBDatabaseTest, PendingDelete) {

EXPECT_TRUE(backing_store->HasOneRef()); // local

IndexedDBFactory* factory = 0;

+ leveldb::Status s;

scoped_refptr<IndexedDBDatabase> db =

IndexedDBDatabase::Create(ASCIIToUTF16("db"),

backing_store,

factory,

- IndexedDBDatabase::Identifier());

+ IndexedDBDatabase::Identifier(),

+ &s);

EXPECT_FALSE(backing_store->HasOneRef()); // local and db