Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 237143004: Initial steps for moving code onto Map (Closed)

Created:
6 years, 8 months ago by Toon Verwaest
Modified:
6 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Initial steps for moving code onto Map BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20736

Patch Set 1 #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -52 lines) Patch
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 7 chunks +27 lines, -51 lines 9 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
6 years, 8 months ago (2014-04-14 15:45:07 UTC) #1
Igor Sheludko
lgtm with nits: https://codereview.chromium.org/237143004/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/237143004/diff/1/src/objects.cc#newcode4423 src/objects.cc:4423: Isolate* isolate = cache->GetIsolate(); While we ...
6 years, 8 months ago (2014-04-14 16:17:52 UTC) #2
Toon Verwaest
As discussed offline, I don't really want to pollute all our code with , isolate, ...
6 years, 8 months ago (2014-04-14 16:20:58 UTC) #3
Toon Verwaest
6 years, 8 months ago (2014-04-14 16:21:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r20736 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698