Enable ARM optimizations for Opus in iOS

Enable ARM optimizations for Opus in iOS

Opus ARM optimizations has been enabled on Android and ChromeOS, but not on iOS because some of the optimizations don't compile for iOS. In this CL I'm enabling the optimizations that do compile.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266564

[tlegrand1, 2014-04-14 15:30:58]

Hi Sergey,

Can you help review this CL that enables ARM optimizations on iOS? Thanks!

https://codereview.chromium.org/237143003/diff/1/third_party/opus/README.chro...
File third_party/opus/README.chromium (right):

https://codereview.chromium.org/237143003/diff/1/third_party/opus/README.chro...
third_party/opus/README.chromium:3: Version: 1.1.0
Noticed that I forgot to update this file when pulling in Opus 1.1.0.

https://codereview.chromium.org/237143003/diff/1/third_party/opus/opus.gyp
File third_party/opus/opus.gyp (right):

https://codereview.chromium.org/237143003/diff/1/third_party/opus/opus.gyp#ne...
third_party/opus/opus.gyp:17: ['OS=="ios"', {
Do we need to specify ARM here, or do iOS implicitly mean ARM?

[Sergey Ulanov, 2014-04-14 21:42:13]

https://codereview.chromium.org/237143003/diff/1/third_party/opus/opus.gyp
File third_party/opus/opus.gyp (right):

https://codereview.chromium.org/237143003/diff/1/third_party/opus/opus.gyp#ne...
third_party/opus/opus.gyp:17: ['OS=="ios"', {
On 2014/04/14 15:30:58, tlegrand1 wrote:
> Do we need to specify ARM here, or do iOS implicitly mean ARM?

I think we do. iOS emulator build are normally compiled for x86, not ARM.

https://codereview.chromium.org/237143003/diff/1/third_party/opus/opus.gyp#ne...
third_party/opus/opus.gyp:22: 'use_opus_fixed_point%': 0,
this duplicates lines 13-15. I suggest formatting this part as follows

["(ios or android or ChromeOS) and arm", {
     'use_opus_fixed_point%': 1,
     'use_opus_arm_optimization%': 1,
}, {
     'use_opus_fixed_point%': 0,
     'use_opus_arm_optimization%': 0,
}],
["android or ChromeOS on arm", {
     'use_opus_rtcd%': 1,
}, {
     'use_opus_rtcd%': 0,
}],

[tlegrand1, 2014-04-15 14:15:21]

Thanks for reviewing!

I think it looks better now, but I needed to specify target_arch==armv7 for iOS.

PTAL.

https://codereview.chromium.org/237143003/diff/1/third_party/opus/opus.gyp
File third_party/opus/opus.gyp (right):

https://codereview.chromium.org/237143003/diff/1/third_party/opus/opus.gyp#ne...
third_party/opus/opus.gyp:17: ['OS=="ios"', {
Thanks, didn't know that.
On 2014/04/14 21:42:13, Sergey Ulanov wrote:
> On 2014/04/14 15:30:58, tlegrand1 wrote:
> > Do we need to specify ARM here, or do iOS implicitly mean ARM?
> 
> I think we do. iOS emulator build are normally compiled for x86, not ARM.

https://codereview.chromium.org/237143003/diff/1/third_party/opus/opus.gyp#ne...
third_party/opus/opus.gyp:22: 'use_opus_fixed_point%': 0,
Needed to specify armv7 for ios.
On 2014/04/14 21:42:13, Sergey Ulanov wrote:
> this duplicates lines 13-15. I suggest formatting this part as follows
> 
> ["(ios or android or ChromeOS) and arm", {
>      'use_opus_fixed_point%': 1,
>      'use_opus_arm_optimization%': 1,
> }, {
>      'use_opus_fixed_point%': 0,
>      'use_opus_arm_optimization%': 0,
> }],
> ["android or ChromeOS on arm", {
>      'use_opus_rtcd%': 1,
> }, {
>      'use_opus_rtcd%': 0,
> }],

[Sergey Ulanov, 2014-04-15 18:46:48]

lgtm

[tlegrand1, 2014-04-28 12:23:21]

The CQ bit was checked by tlegrand@chromium.org

[commit-bot: I haz the power, 2014-04-28 12:23:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tlegrand@chromium.org/237143003/40001

[commit-bot: I haz the power, 2014-04-28 14:41:10]

Change committed as 266564