Fix LoginPromptBrowserTest.TestCancelAuth_OnNavigation test flakiness.

Fix LoginPromptBrowserTest.TestCancelAuth_OnNavigation test flakiness.

On navigation to a different origin (empty page -> kAuthUrl) we have an interstitial which generates an additional LOAD_STOP event. We should count it in WindowedLoadStopObserver.

BUG=648826
R=vabr@chromium.org

Committed: https://crrev.com/ccdf28fd10f131452af38b709106bd14409d5c06
Cr-Commit-Position: refs/heads/master@{#421481}

[sense (YandexTeam), 2016-09-28 06:10:15]

Description was changed from

==========
Fix LoginPromptBrowserTest.TestCancelAuth_OnNavigation test flakiness.

BUG=648826
R=vabr@chromium.org
==========

to

==========
Fix LoginPromptBrowserTest.TestCancelAuth_OnNavigation test flakiness.

On navigation to a different origin (empty page -> kAuthUrl) we have an
interstitial which generates an additional LOAD_STOP event. We should count it
in WindowedLoadStopObserver.

BUG=648826
R=vabr@chromium.org
==========

[vabr (Chromium), 2016-09-28 07:31:05]

LGTM, looks reasonable. Thanks for the investigation and fix!

Cheers,
Vaclav

[sense (YandexTeam), 2016-09-28 07:53:49]

The CQ bit was checked by sense@yandex-team.ru

[commit-bot: I haz the power, 2016-09-28 07:54:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 08:27:59]

Description was changed from

==========
Fix LoginPromptBrowserTest.TestCancelAuth_OnNavigation test flakiness.

On navigation to a different origin (empty page -> kAuthUrl) we have an
interstitial which generates an additional LOAD_STOP event. We should count it
in WindowedLoadStopObserver.

BUG=648826
R=vabr@chromium.org
==========

to

==========
Fix LoginPromptBrowserTest.TestCancelAuth_OnNavigation test flakiness.

On navigation to a different origin (empty page -> kAuthUrl) we have an
interstitial which generates an additional LOAD_STOP event. We should count it
in WindowedLoadStopObserver.

BUG=648826
R=vabr@chromium.org
==========

[commit-bot: I haz the power, 2016-09-28 08:28:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-28 08:31:00]

Description was changed from

==========
Fix LoginPromptBrowserTest.TestCancelAuth_OnNavigation test flakiness.

On navigation to a different origin (empty page -> kAuthUrl) we have an
interstitial which generates an additional LOAD_STOP event. We should count it
in WindowedLoadStopObserver.

BUG=648826
R=vabr@chromium.org
==========

to

==========
Fix LoginPromptBrowserTest.TestCancelAuth_OnNavigation test flakiness.

On navigation to a different origin (empty page -> kAuthUrl) we have an
interstitial which generates an additional LOAD_STOP event. We should count it
in WindowedLoadStopObserver.

BUG=648826
R=vabr@chromium.org

Committed: https://crrev.com/ccdf28fd10f131452af38b709106bd14409d5c06
Cr-Commit-Position: refs/heads/master@{#421481}
==========

[commit-bot: I haz the power, 2016-09-28 08:31:01]

Patchset 1 (id:??) landed as
https://crrev.com/ccdf28fd10f131452af38b709106bd14409d5c06
Cr-Commit-Position: refs/heads/master@{#421481}

[nasko, 2016-09-28 14:03:50]

On 2016/09/28 08:31:01, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/ccdf28fd10f131452af38b709106bd14409d5c06
> Cr-Commit-Position: refs/heads/master@{#421481}

This CL is causing failures on the PlzNavigate bot:
https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigatio....

[vabr (Chromium), 2016-09-28 14:10:06]

On 2016/09/28 14:03:50, nasko (slow) wrote:
> On 2016/09/28 08:31:01, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/ccdf28fd10f131452af38b709106bd14409d5c06
> > Cr-Commit-Position: refs/heads/master@{#421481}
> 
> This CL is causing failures on the PlzNavigate bot:
>
https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigatio....

Thanks for the info, nasko@.

Ad sense@ -- the test is timing out with PlzNavigate turned on. Perhaps
PlzNavigate influences the number of LOAD_STOP events received? Could you please
investigate? Passing --enable-browser-side-navigation to browser_tests should
enable PlzNavigate in the tests.

Cheers,
Vaclav

[jam, 2016-09-28 15:02:45]

there is one less load for plznavigate because we don't get a load_stop for
ongoing navigation when we navigate. see other lines in that file that have
comments/code to handle this (i.e. content::IsBrowserSideNavigationEnabled()
checks)

[vabr (Chromium), 2016-09-28 15:28:00]

On 2016/09/28 15:02:45, jam wrote:
> there is one less load for plznavigate because we don't get a load_stop for
> ongoing navigation when we navigate. see other lines in that file that have
> comments/code to handle this (i.e. content::IsBrowserSideNavigationEnabled()
> checks)

Thanks, jam@!

I'll try to put together a CL to fix this and send it to nasko@.

Cheers,
Vaclav