Chromium Code Reviews

Issue 2371403003: [wasm] fix for GC during instantiation. (Closed)

Created:
4 years, 2 months ago by Mircea Trofin
Modified:
4 years, 2 months ago
Reviewers:
titzer, bradnelson
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] fix for GC during instantiation. BUG=chromium:651070 Committed: https://crrev.com/aff5ab11321d9a9d297260d32d0a004bd348913d Cr-Commit-Position: refs/heads/master@{#39848}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+138 lines, -10 lines)
M src/wasm/wasm-module.cc View 3 chunks +31 lines, -10 lines 0 comments
A test/mjsunit/regress/wasm/regression-02862.js View 1 chunk +107 lines, -0 lines 0 comments

Messages

Total messages: 15 (9 generated)
Mircea Trofin
4 years, 2 months ago (2016-09-28 23:44:31 UTC) #5
titzer
lgtm I like this solution much better than the previous manual GC solution!
4 years, 2 months ago (2016-09-29 04:19:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371403003/1
4 years, 2 months ago (2016-09-29 04:21:43 UTC) #10
Mircea Trofin
On 2016/09/29 04:19:22, titzer wrote: > lgtm > > I like this solution much better ...
4 years, 2 months ago (2016-09-29 04:22:34 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 04:24:23 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 04:24:50 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/aff5ab11321d9a9d297260d32d0a004bd348913d
Cr-Commit-Position: refs/heads/master@{#39848}

Powered by Google App Engine