test.py: Print the warning about left-over dirs only for directories created using Directory.create…

tools/testing/dart/test_progress.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test_progress;
 
+import "dart:async";
 import "dart:io";
 import "dart:io" as io;
 import "http_server.dart" as http_server;
 import "status_file_parser.dart";
 import "test_runner.dart";
 import "test_suite.dart";
 import "utils.dart";
 
 String _pad(String s, int length) {
   StringBuffer buffer = new StringBuffer();
@@ skipping 303 matching lines @@
     if (_skippedCompilations > 0) {
       print('\n$_skippedCompilations compilations were skipped because '
             'the previous output was already up to date\n');
     }
   }
 }
 
 class LeftOverTempDirPrinter extends EventListener {
   final MIN_NUMBER_OF_TEMP_DIRS = 50;
 
-  Path _tempDir() {
+  static Directory _getTemporaryDirectory() {
     // Dir will be located in the system temporary directory.
     var dir = new Directory('').createTempSync();
     var path = new Path(dir.path).directoryPath;
     dir.deleteSync();
-    return path;
+    return new Directory(path.toNativePath());
+  }
+
+  static RegExp _getTemporaryDirectoryRegexp() {
+    // These are the patterns of temporary directory names created by
+    // 'Directory.createTempSync()' on linux/macos and windows.
+    if (['macos', 'linux'].contains(Platform.operatingSystem)) {
+      return new RegExp(r'^temp_dir1_......$');
+    } else {
+      return new RegExp(r'tempdir-........-....-....-....-............$');
+    }
+  }
+
+  static Stream<Directory> getLeftOverTemporaryDirectories() {
+    var regExp = _getTemporaryDirectoryRegexp();
+    return _getTemporaryDirectory().list().where(
+        (FileSystemEntity fse) {
+          if (fse is Directory) {
+            if (regExp.hasMatch(new Path(fse.path).filename)) {
+              return true;
+            }
+          }
+          return false;
+        });
   }
 
   void allDone() {
-    var count = 0;
-    var systemTempDir = _tempDir();
-    var lister = new Directory(systemTempDir.toNativePath()).list().listen(
-        (FileSystemEntity fse) {
-          if (fse is Directory) count++;
-        },
-        onError: (error) {
-          DebugLogger.warning("Could not list temp directories, got: $error");
-        },
-        onDone: () {
-          if (count > MIN_NUMBER_OF_TEMP_DIRS) {
-            DebugLogger.warning("There are ${count} directories "
-                                "in the system tempdir ('$systemTempDir')! "
-                                "Maybe left over directories?\n");
+    getLeftOverTemporaryDirectories().length.then((int count) {
+      if (count > MIN_NUMBER_OF_TEMP_DIRS) {
+        DebugLogger.warning("There are ${count} directories "
+                            "in the system tempdir "
+                            "('${_getTemporaryDirectory().path}')! "
+                            "Maybe left over directories?\n");
       }
+    }).catchError((error) {
+      DebugLogger.warning("Could not list temp directories, got: $error");
     });
   }
 }
 
 class LineProgressIndicator extends EventListener {
   void done(TestCase test) {
     var status = 'pass';
     if (test.unexpectedOutput) {
       status = 'fail';
     }
@@ skipping 175 matching lines @@
       return new VerboseProgressIndicator(startTime);
     case 'status':
       return new ProgressIndicator(startTime);
     case 'buildbot':
       return new BuildbotProgressIndicator(startTime);
     default:
       assert(false);
       break;
   }
 }