Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2371383003: MD Downloads/History: make javascript uglier and more compact (Closed)

Created:
4 years, 2 months ago by Dan Beam
Modified:
4 years, 2 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, asanka, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads/History: make javascript uglier and more compact This CL removes the --beautify option from the uglifyjs step in vulcanize.py. This reduces resource size at the cost of code readability. Before: $ du -sh chrome/browser/resources/md_*/*crisper.js 208K chrome/browser/resources/md_downloads/crisper.js 168K chrome/browser/resources/md_history/app.crisper.js 100K chrome/browser/resources/md_history/lazy_load.crisper.js After: $ du -sh chrome/browser/resources/md_*/*crisper.js 156K chrome/browser/resources/md_downloads/crisper.js 128K chrome/browser/resources/md_history/app.crisper.js 76K chrome/browser/resources/md_history/lazy_load.crisper.js Seems to save 52K for downloads and 64K for history's resources. R=tsergeant@chromium.org BUG=629710 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/05f3dc10c223b31bb487259c8515dd93852df4c9 Cr-Commit-Position: refs/heads/master@{#421565}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -15723 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 1 chunk +21 lines, -6979 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/app.crisper.js View 1 1 chunk +22 lines, -5463 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/lazy_load.crisper.js View 1 chunk +7 lines, -3279 lines 0 comments Download
M chrome/browser/resources/md_history/lazy_load.vulcanized.html View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/vulcanize.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 22 (16 generated)
Dan Beam
4 years, 2 months ago (2016-09-28 04:43:48 UTC) #5
tsergeant
lgtm with a rebase and update. Let's see if this improves anything.
4 years, 2 months ago (2016-09-28 07:29:31 UTC) #10
Dan Beam
On 2016/09/28 07:29:31, tsergeant wrote: > lgtm with a rebase and update. Let's see if ...
4 years, 2 months ago (2016-09-28 16:34:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371383003/20001
4 years, 2 months ago (2016-09-28 17:54:29 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-28 18:01:06 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 18:04:25 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/05f3dc10c223b31bb487259c8515dd93852df4c9
Cr-Commit-Position: refs/heads/master@{#421565}

Powered by Google App Engine
This is Rietveld 408576698