Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7410)

Unified Diff: chrome/browser/resources/md_history/app.crisper.js

Issue 2371363002: [MD History] Fix item selection when deleting via menu item. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/app.crisper.js
diff --git a/chrome/browser/resources/md_history/app.crisper.js b/chrome/browser/resources/md_history/app.crisper.js
index e6c08baa1f5371681f39411a52f209fb17b4ecca..24b9cf3b233e96344c2c9b209b774063109ea54c 100644
--- a/chrome/browser/resources/md_history/app.crisper.js
+++ b/chrome/browser/resources/md_history/app.crisper.js
@@ -4865,8 +4865,8 @@ Polymer({
var menu = assert(this.$.sharedMenu.getIfExists());
var itemData = menu.itemData;
browserService.deleteItems([ itemData.item ]).then(function(items) {
- this.getSelectedList_().removeItemsByPath([ itemData.path ]);
this.fire('unselect-all');
+ this.getSelectedList_().removeItemsByPath([ itemData.path ]);
var index = itemData.index;
if (index == undefined) return;
var browserService = md_history.BrowserService.getInstance();

Powered by Google App Engine
This is Rietveld 408576698