[SPInvalidation ] Fix scroll offset issue of vertical-rl contents

[SPInvalidation ] Fix scroll offset issue of vertical-rl contents

When calculating scroll offset of contents, we should use LayoutBox::
scrolledContentOffset() instead of ScrollableArea::scrollOffeset().
The former is aware of scrollbar offset in a vertical-rl container.

This fixes paint/invalidation/vertical-overflow-parent.html and
paint/invalidation/vertical-overflow-same.html in slimmingPaintInvalidation
mode.

BUG=650843
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/9f4b2b6143b8eb2facf147471330879932c22944
Cr-Commit-Position: refs/heads/master@{#421581}

[Xianzhu, 2016-09-28 01:15:14]

Description was changed from

==========
[SPInvalidation ] Fix scroll offset issue of vertical-rl contents

When calculating scroll offset of contents, we should use LayoutBox::
scrolledContentOffset() instead of ScrollableArea::scrollOffeset().
The former is aware of scrollbar offset in a vertical-rl container.

This fixes paint/invalidation/vertical-overflow-parent.html and
paint/invalidation/vertical-overflow-same.html in slimmingPaintInvalidation
mode.

BUG=658043
==========

to

==========
[SPInvalidation ] Fix scroll offset issue of vertical-rl contents

When calculating scroll offset of contents, we should use LayoutBox::
scrolledContentOffset() instead of ScrollableArea::scrollOffeset().
The former is aware of scrollbar offset in a vertical-rl container.

This fixes paint/invalidation/vertical-overflow-parent.html and
paint/invalidation/vertical-overflow-same.html in slimmingPaintInvalidation
mode.

BUG=658043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-09-28 01:15:16]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 01:15:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 01:18:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 01:18:19]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2016-09-28 03:41:30]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 03:41:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 04:38:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 04:38:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2016-09-28 16:52:24]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 16:52:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-09-28 16:52:50]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2016-09-28 18:04:40]

LGTM

We use FrameView::scrollOffset for the non-root-layer-scrolls codepath
(PaintPropertyTreeBuilder::buildTreeNodes(frameview, ...)). Do we need to change
that too? vertical-rl at the root is a little strange so I'm not sure. This
change is good regardless.

[commit-bot: I haz the power, 2016-09-28 18:13:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 18:13:53]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2016-09-28 18:22:23]

On 2016/09/28 18:04:40, pdr. wrote:
> LGTM
> 
> We use FrameView::scrollOffset for the non-root-layer-scrolls codepath
> (PaintPropertyTreeBuilder::buildTreeNodes(frameview, ...)). Do we need to
change
> that too? vertical-rl at the root is a little strange so I'm not sure. This
> change is good regardless.

I think that doesn't matter. For vertical-rl box case, the box's geometry
includes the scrollbar, so we need a special offset to shift the origin (the
physical top-right corner) of the children. For FrameView on-root-layer-scrolls
path, the scrollbar is not a part of the layout space of the LayoutView.

[Xianzhu, 2016-09-28 18:22:35]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-09-28 18:23:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 18:29:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-28 18:31:18]

Description was changed from

==========
[SPInvalidation ] Fix scroll offset issue of vertical-rl contents

When calculating scroll offset of contents, we should use LayoutBox::
scrolledContentOffset() instead of ScrollableArea::scrollOffeset().
The former is aware of scrollbar offset in a vertical-rl container.

This fixes paint/invalidation/vertical-overflow-parent.html and
paint/invalidation/vertical-overflow-same.html in slimmingPaintInvalidation
mode.

BUG=658043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[SPInvalidation ] Fix scroll offset issue of vertical-rl contents

When calculating scroll offset of contents, we should use LayoutBox::
scrolledContentOffset() instead of ScrollableArea::scrollOffeset().
The former is aware of scrollbar offset in a vertical-rl container.

This fixes paint/invalidation/vertical-overflow-parent.html and
paint/invalidation/vertical-overflow-same.html in slimmingPaintInvalidation
mode.

BUG=658043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/9f4b2b6143b8eb2facf147471330879932c22944
Cr-Commit-Position: refs/heads/master@{#421581}
==========

[commit-bot: I haz the power, 2016-09-28 18:31:19]

Patchset 3 (id:??) landed as
https://crrev.com/9f4b2b6143b8eb2facf147471330879932c22944
Cr-Commit-Position: refs/heads/master@{#421581}

[Xianzhu, 2016-10-05 22:08:15]

Description was changed from

==========
[SPInvalidation ] Fix scroll offset issue of vertical-rl contents

When calculating scroll offset of contents, we should use LayoutBox::
scrolledContentOffset() instead of ScrollableArea::scrollOffeset().
The former is aware of scrollbar offset in a vertical-rl container.

This fixes paint/invalidation/vertical-overflow-parent.html and
paint/invalidation/vertical-overflow-same.html in slimmingPaintInvalidation
mode.

BUG=658043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/9f4b2b6143b8eb2facf147471330879932c22944
Cr-Commit-Position: refs/heads/master@{#421581}
==========

to

==========
[SPInvalidation ] Fix scroll offset issue of vertical-rl contents

When calculating scroll offset of contents, we should use LayoutBox::
scrolledContentOffset() instead of ScrollableArea::scrollOffeset().
The former is aware of scrollbar offset in a vertical-rl container.

This fixes paint/invalidation/vertical-overflow-parent.html and
paint/invalidation/vertical-overflow-same.html in slimmingPaintInvalidation
mode.

BUG=650843
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/9f4b2b6143b8eb2facf147471330879932c22944
Cr-Commit-Position: refs/heads/master@{#421581}
==========