Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3569)

Unified Diff: man/html/depot_tools_tutorial.html

Issue 2371333002: Modify depot_tools instructions regarding %PATH% (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: man/html/depot_tools_tutorial.html
diff --git a/man/html/depot_tools_tutorial.html b/man/html/depot_tools_tutorial.html
index d55999b03d8caa9131d936dd108c8ca53038b23b..c80a092676f7b4f39899deb0927a8fd4b4ef844b 100644
--- a/man/html/depot_tools_tutorial.html
+++ b/man/html/depot_tools_tutorial.html
@@ -898,8 +898,8 @@ extract the hidden &#8220;.git&#8221; folder which is necessary for <em>depot_to
autoupdate itself. You can use &#8220;Extract all&#8230;&#8221; from the context menu though.</td>
</tr></table>
</div>
-<div class="paragraph"><p>Add <em>depot_tools</em> to the <em>end</em> of your PATH. Assuming you unzipped the
-bundle to <code>C:\workspace\depot_tools</code>:</p></div>
+<div class="paragraph"><p>Add <em>depot_tools</em> to the <em>start</em> of your PATH (must be ahead of any
+installs of Python). Assuming you unzipped the bundle to <code>C:\workspace\depot_tools</code>:</p></div>
<div class="dlist"><dl>
<dt class="hdlist1">
With Administrator access:
@@ -917,7 +917,7 @@ Without Administrator access:
<p>
<strong>Control Panel &#8594; User Accounts &#8594; User Accounts &#8594; Change my environment variables</strong>
</p>
-<div class="paragraph"><p>Add a PATH user variable: <code>%PATH%;C:\workspace\depot_tools</code>.</p></div>
+<div class="paragraph"><p>Add a PATH user variable: <code>C:\workspace\depot_tools;%PATH%</code>.</p></div>
</dd>
</dl></div>
<div class="paragraph"><p>From a <code>cmd.exe</code> shell, run the command <code>gclient</code> (without arguments). On first
@@ -946,10 +946,9 @@ If you see strange errors with the file system on the first run of gclient,
</li>
<li>
<p>
-If you are running Windows XP and see errors like &#8220;The system cannot execute
- the specified program&#8221;, try installing the
- <a href="http://code.google.com/p/chromium/issues/detail?id=75886">&#8220;Microsoft
- Visual C++ 2008 Redistributable Package&#8221;</a>.
+After running gclient open a command prompt and type where python and confirm that
agable 2016/09/28 16:10:04 ...and type `where python` to confirm...
brucedawson 2016/09/28 20:32:34 Done.
+ the depot_tools python.bat comes ahead of any copies of python.exe. Failing to ensure
+ this can lead to overbuilding when using gn - see <a href="crbug.com/611087">crbug.com/611087</a>
</p>
</li>
</ul></div>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698