reflow comments in wtf/allocator

reflow comments in wtf/allocator

BUG=563793
Committed: https://crrev.com/d2a38acd7c8f91971cd83a4dae1343ddb7a21496
Cr-Commit-Position: refs/heads/master@{#422341}

[Nico, 2016-10-01 17:03:20]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-01 17:03:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-10-01 17:04:33]

thakis@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-10-01 17:55:23]

LGTM with some nits

https://codereview.chromium.org/2371323009/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h (left):

https://codereview.chromium.org/2371323009/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h:269: numAllocatedSlots;
 // Deliberately signed, 0 for empty or decommitted page, -n for full pages.
Nit: just place this on the prior line?

https://codereview.chromium.org/2371323009/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h (right):

https://codereview.chromium.org/2371323009/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h:179: //    
PartitionBucket (32B) | PartitionDirectMapExtent (8B) |
Nit: I feel like this is kind of hard to read once it's wrapped, it almost looks
like it's ORing flags together.

Though it's a more extensive change, maybe we could put the wrapped things in
boxes?

   ,------------------------------------------.
   |        SuperPageExtentEntry(32B)         |
   |------------------------------------------|
   | PartitionPage of slot span 1 (32B, used) |


etc?

https://codereview.chromium.org/2371323009/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h:363: // sizes.
Nit: Merge the next line

[commit-bot: I haz the power, 2016-10-01 19:31:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 19:31:59]

Dry run: This issue passed the CQ dry run.

[Nico, 2016-10-01 19:47:01]

https://codereview.chromium.org/2371323009/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h (left):

https://codereview.chromium.org/2371323009/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h:269: numAllocatedSlots;
 // Deliberately signed, 0 for empty or decommitted page, -n for full pages.
On 2016/10/01 17:55:23, dcheng wrote:
> Nit: just place this on the prior line?

Done.

https://codereview.chromium.org/2371323009/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h:269: numAllocatedSlots;
 // Deliberately signed, 0 for empty or decommitted page, -n for full pages.
On 2016/10/01 17:55:23, dcheng wrote:
> Nit: just place this on the prior line?

Done.

https://codereview.chromium.org/2371323009/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h (right):

https://codereview.chromium.org/2371323009/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h:179: //    
PartitionBucket (32B) | PartitionDirectMapExtent (8B) |
On 2016/10/01 17:55:23, dcheng wrote:
> Nit: I feel like this is kind of hard to read once it's wrapped, it almost
looks
> like it's ORing flags together.
> 
> Though it's a more extensive change, maybe we could put the wrapped things in
> boxes?
> 
>    ,------------------------------------------.
>    |        SuperPageExtentEntry(32B)         |
>    |------------------------------------------|
>    | PartitionPage of slot span 1 (32B, used) |
> 
> 
> etc?

Did that but without the ----- lines. wdty?

https://codereview.chromium.org/2371323009/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h:363: // sizes.
On 2016/10/01 17:55:23, dcheng wrote:
> Nit: Merge the next line

Done.

[Nico, 2016-10-01 19:47:26]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-01 19:47:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-10-01 19:50:02]

LGTM

https://codereview.chromium.org/2371323009/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h (right):

https://codereview.chromium.org/2371323009/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h:157: //   \ ...        
        |
Nit: I think \ is supposed to be a |

[commit-bot: I haz the power, 2016-10-01 21:19:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 21:19:21]

Dry run: This issue passed the CQ dry run.

[Nico, 2016-10-02 00:44:18]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-10-02 00:44:18]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2371323009/#ps40001
(title: "no backslash")

[commit-bot: I haz the power, 2016-10-02 00:44:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-10-02 00:44:32]

https://codereview.chromium.org/2371323009/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h (right):

https://codereview.chromium.org/2371323009/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h:157: //   \ ...        
        |
On 2016/10/01 19:50:02, dcheng wrote:
> Nit: I think \ is supposed to be a |

Done.

[commit-bot: I haz the power, 2016-10-02 02:59:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-02 03:01:18]

Description was changed from

==========
reflow comments in wtf/allocator

BUG=563793
==========

to

==========
reflow comments in wtf/allocator

BUG=563793

Committed: https://crrev.com/d2a38acd7c8f91971cd83a4dae1343ddb7a21496
Cr-Commit-Position: refs/heads/master@{#422341}
==========

[commit-bot: I haz the power, 2016-10-02 03:01:19]

Patchset 3 (id:??) landed as
https://crrev.com/d2a38acd7c8f91971cd83a4dae1343ddb7a21496
Cr-Commit-Position: refs/heads/master@{#422341}